From: Shahed Shaikh <shshaikh@marvell.com> To: Dekel Peled <dekelp@mellanox.com>, "john.mcnamara@intel.com" <john.mcnamara@intel.com>, "marko.kovacevic@intel.com" <marko.kovacevic@intel.com>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>, "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "matan@mellanox.com" <matan@mellanox.com>, "shahafs@mellanox.com" <shahafs@mellanox.com>, "viacheslavo@mellanox.com" <viacheslavo@mellanox.com>, Rasesh Mody <rmody@marvell.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "tiwei.bie@intel.com" <tiwei.bie@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "yongwang@vmware.com" <yongwang@vmware.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, "bernard.iremonger@intel.com" <bernard.iremonger@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size Date: Thu, 7 Nov 2019 11:57:14 +0000 Message-ID: <BYAPR18MB26968F22FA882D51D9ABFCB1D3780@BYAPR18MB2696.namprd18.prod.outlook.com> (raw) In-Reply-To: <87548a8a0d7d549bd7fb788be197c90712785ad3.1573050134.git.dekelp@mellanox.com> > -----Original Message----- > From: Dekel Peled <dekelp@mellanox.com> > Sent: Wednesday, November 6, 2019 7:58 PM > To: john.mcnamara@intel.com; marko.kovacevic@intel.com; > nhorman@tuxdriver.com; ajit.khaparde@broadcom.com; > somnath.kotur@broadcom.com; anatoly.burakov@intel.com; > xuanziyang2@huawei.com; cloud.wangxiaoyun@huawei.com; > zhouguoyang@huawei.com; wenzhuo.lu@intel.com; > konstantin.ananyev@intel.com; matan@mellanox.com; > shahafs@mellanox.com; viacheslavo@mellanox.com; Rasesh Mody > <rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; > maxime.coquelin@redhat.com; tiwei.bie@intel.com; zhihong.wang@intel.com; > yongwang@vmware.com; thomas@monjalon.net; ferruh.yigit@intel.com; > arybchenko@solarflare.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org > Subject: [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size > > External Email > > ---------------------------------------------------------------------- > This patch implements [1], to support API for configuration and > > validation of max size for LRO aggregated packet. > > API change notice [2] is removed, and release notes for 19.11 > > are updated accordingly. > > > > Various PMDs using LRO offload are updated, the new data members are > > initialized to ensure they don't fail validation. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=http- > 3A__patches.dpdk.org_patch_58217_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtf > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ANfM9GH > SB9nUhm8O8YaoqcXO0eTBO7TmGhVmekbNO6U&e= > > [2] https://urldefense.proofpoint.com/v2/url?u=http- > 3A__patches.dpdk.org_patch_57492_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtf > Q&r=qeevDAWea4uZZbQhISypy6IVgD4EOfIP7D- > cw6N6nsI&m=ghr6KiUvwMCjBQ7KRJJ8BfoTOHlY9gICprAIn4yao9A&s=ppYVWXe > Jj3xhnvWCV2hIfNu6wy9N2r5lvJxgJnHKfSc&e= > > > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > > Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> > > Acked-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > doc/guides/nics/features.rst | 2 ++ > > doc/guides/rel_notes/deprecation.rst | 4 --- > > doc/guides/rel_notes/release_19_11.rst | 8 ++++++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > drivers/net/mlx5/mlx5.h | 3 +++ > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > drivers/net/mlx5/mlx5_rxq.c | 1 - > > drivers/net/qede/qede_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_ethdev/rte_ethdev.c | 44 > ++++++++++++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 4 +++ > > 15 files changed, 70 insertions(+), 5 deletions(-) > > @@ -1277,6 +1277,7 @@ static int qede_dev_configure(struct rte_eth_dev > *eth_dev) > > > > dev_info->min_rx_bufsize = (uint32_t)QEDE_MIN_RX_BUFF_SIZE; > > dev_info->max_rx_pktlen = > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN; > > + dev_info->max_lro_pkt_size = > (uint32_t)ETH_TX_MAX_NON_LSO_PKT_LEN Please use 0x7FFF instead of ETH_TX_MAX_NON_LSO_PKT_LEN. We set the same limit in qede_ethdev.c: qede_update_sge_tpa_params() sge_tpa_params->tpa_max_size = 0x7FFF; Thanks, Shahed > > dev_info->rx_desc_lim = qede_rx_desc_lim; > > dev_info->tx_desc_lim = qede_tx_desc_lim; > >
next prev parent reply index Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 8:40 [dpdk-dev] [PATCH 0/3] " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 1/3] ethdev: " Dekel Peled 2019-11-05 12:39 ` Andrew Rybchenko 2019-11-05 13:09 ` Thomas Monjalon 2019-11-05 14:18 ` Dekel Peled 2019-11-05 14:27 ` Andrew Rybchenko 2019-11-05 14:51 ` Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 2/3] net/mlx5: use " Dekel Peled 2019-11-05 8:40 ` [dpdk-dev] [PATCH 3/3] app/testpmd: " Dekel Peled 2019-11-05 9:35 ` [dpdk-dev] [PATCH 0/3] support " Matan Azrad 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 1/3] ethdev: " Dekel Peled 2019-11-06 12:26 ` Thomas Monjalon 2019-11-06 12:39 ` Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 2/3] net/mlx5: use " Dekel Peled 2019-11-06 11:34 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: " Dekel Peled 2019-11-06 12:35 ` Iremonger, Bernard 2019-11-06 13:14 ` Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 0/3] support " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 1/3] ethdev: " Dekel Peled 2019-11-07 11:57 ` Shahed Shaikh [this message] 2019-11-07 12:18 ` [dpdk-dev] [EXT] " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 2/3] net/mlx5: use " Dekel Peled 2019-11-06 14:28 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: " Dekel Peled 2019-11-06 16:41 ` [dpdk-dev] [PATCH v3 0/3] support " Iremonger, Bernard 2019-11-07 6:10 ` Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 " Dekel Peled 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 1/3] ethdev: " Dekel Peled 2019-11-07 20:15 ` Ferruh Yigit 2019-11-08 6:54 ` Matan Azrad 2019-11-08 9:19 ` Ferruh Yigit 2019-11-08 10:10 ` Matan Azrad 2019-11-08 11:37 ` Ferruh Yigit 2019-11-08 11:56 ` Matan Azrad 2019-11-08 12:51 ` Ferruh Yigit 2019-11-08 16:11 ` Dekel Peled 2019-11-08 16:53 ` Ferruh Yigit 2019-11-09 18:20 ` Matan Azrad 2019-11-10 23:40 ` Ananyev, Konstantin 2019-11-11 8:01 ` Matan Azrad 2019-11-12 18:31 ` Ananyev, Konstantin 2019-11-11 11:15 ` Ferruh Yigit 2019-11-11 11:33 ` Matan Azrad 2019-11-11 12:21 ` Ferruh Yigit 2019-11-11 13:32 ` Matan Azrad 2019-11-08 13:11 ` Ananyev, Konstantin 2019-11-08 14:10 ` Dekel Peled 2019-11-08 14:52 ` Ananyev, Konstantin 2019-11-08 16:08 ` Dekel Peled 2019-11-08 16:28 ` Ananyev, Konstantin 2019-11-09 18:26 ` Matan Azrad 2019-11-10 22:51 ` Ananyev, Konstantin 2019-11-11 6:53 ` Matan Azrad 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 2/3] net/mlx5: use " Dekel Peled 2019-11-08 9:12 ` Slava Ovsiienko 2019-11-08 9:23 ` Ferruh Yigit 2019-11-07 12:35 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: " Dekel Peled 2019-11-07 14:20 ` Iremonger, Bernard 2019-11-07 20:25 ` Ferruh Yigit 2019-11-08 6:56 ` Matan Azrad 2019-11-08 13:58 ` Dekel Peled 2019-11-08 6:28 ` [dpdk-dev] [PATCH v4 0/3] support " Matan Azrad 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 1/3] ethdev: " Dekel Peled 2019-11-10 23:07 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 2/3] net/mlx5: use " Dekel Peled 2019-11-08 16:42 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: " Dekel Peled 2019-11-10 23:11 ` Ananyev, Konstantin 2019-11-11 7:40 ` Dekel Peled 2019-11-08 23:07 ` [dpdk-dev] [PATCH v6] ethdev: add " Thomas Monjalon 2019-11-10 22:47 ` Ananyev, Konstantin 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 0/3] support API to set " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 1/3] ethdev: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 2/3] net/mlx5: use " Dekel Peled 2019-11-11 17:47 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: " Dekel Peled 2019-11-12 0:46 ` Ferruh Yigit 2019-11-12 0:47 ` [dpdk-dev] [PATCH v7 0/3] support " Ferruh Yigit
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR18MB26968F22FA882D51D9ABFCB1D3780@BYAPR18MB2696.namprd18.prod.outlook.com \ --to=shshaikh@marvell.com \ --cc=ajit.khaparde@broadcom.com \ --cc=anatoly.burakov@intel.com \ --cc=arybchenko@solarflare.com \ --cc=bernard.iremonger@intel.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=dekelp@mellanox.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jingjing.wu@intel.com \ --cc=john.mcnamara@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=matan@mellanox.com \ --cc=maxime.coquelin@redhat.com \ --cc=nhorman@tuxdriver.com \ --cc=rmody@marvell.com \ --cc=shahafs@mellanox.com \ --cc=somnath.kotur@broadcom.com \ --cc=thomas@monjalon.net \ --cc=tiwei.bie@intel.com \ --cc=viacheslavo@mellanox.com \ --cc=wenzhuo.lu@intel.com \ --cc=xuanziyang2@huawei.com \ --cc=yongwang@vmware.com \ --cc=zhihong.wang@intel.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions Archives are clonable: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/ public-inbox