DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>,
	Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	"Ajit Khaparde" <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to reset Rx next consumer index
Date: Fri, 20 Aug 2021 13:46:57 +0100	[thread overview]
Message-ID: <64bb2ddc-f160-ee25-51c4-917141898b0c@intel.com> (raw)
In-Reply-To: <20210810060731.30127-1-somnath.kotur@broadcom.com>

On 8/10/2021 7:07 AM, Somnath Kotur wrote:
> In bnxt_init_one_rx_ring(), reset this variable internal to the driver
> ring to 0, so that there is no mismatch with actual value in HW on
> traffic resumption.
> 

Hi Somnath,

What is the impact of the patch, what are you fixing?

If the 'rx_next_cons' (next consumer index) is not matching with HW value, what
happens, does the Rx fails completely and unrecoverable? Or does miss one or
more packet?

And when/how this happens, since driver is not new I assume this doesn't happen
in first ring init. Does this happen after uninit and init again? Providing this
information helps clarifying scope of the fix.

Can you please send a new version with updated commit log?

Thanks,
ferruh

> Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_rxr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index aea71703d1..73fbdd17d1 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -1379,6 +1379,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
>  	}
>  	PMD_DRV_LOG(DEBUG, "TPA alloc Done!\n");
>  
> +	/* Explicitly reset this driver internal tracker on a ring init */
> +	rxr->rx_next_cons = 0;
> +
>  	return 0;
>  }
>  
> 


  parent reply	other threads:[~2021-08-20 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  6:07 Somnath Kotur
2021-08-19  4:48 ` Ajit Khaparde
2021-08-20 12:46 ` Ferruh Yigit [this message]
2021-08-23  6:38   ` Somnath Kotur
2021-08-23  6:33 ` [dpdk-dev] [PATCH v2] " Somnath Kotur
2021-08-23 14:43 ` [dpdk-dev] [PATCH v3] net/bnxt: fix crash after port stop/start Somnath Kotur
2021-08-23 15:43 ` [dpdk-dev] [PATCH v4] " Somnath Kotur
2021-08-23 15:44 ` Somnath Kotur
2021-08-24  1:51   ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64bb2ddc-f160-ee25-51c4-917141898b0c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).