DPDK patches and discussions
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yong Wang <yongwang@vmware.com>,
	Eduard Serra Miralles <eserra@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: fix RSS setting on v4
Date: Tue, 8 Oct 2019 18:55:09 +0100
Message-ID: <66a78992-5fc7-191f-9f87-0fe30d0a190a@intel.com> (raw)
In-Reply-To: <8FBE8D68-AB07-4E50-BD9E-53700207A0CD@vmware.com>

On 9/16/2019 8:01 PM, Yong Wang wrote:
> From: Eduard Serra Miralles <eserra@vmware.com>
> Date: Friday, September 13, 2019 at 1:10 PM
> To: Yong Wang <yongwang@vmware.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4
> I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail.
> ________________________________
> From: Yong Wang <yongwang@vmware.com>
> Sent: Friday, September 13, 2019 11:44:38 AM
> To: Eduard Serra Miralles <eserra@vmware.com>
> Cc: dev@dpdk.org <dev@dpdk.org>
> Subject: Re: [PATCH] net/vmxnet3: fix RSS setting on v4
> -----Original Message-----
> From: Eduard Serra Miralles <eserra@vmware.com>
> Date: Wednesday, August 21, 2019 at 9:37 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>
> Subject: [PATCH] net/vmxnet3: fix RSS setting on v4
>     When calling to setup RSS on v4 API, ESX will expect
>     IPv4/6 TCP RSS to be set/requested mandatorily.
>     This patch will:
>     - Set IPv4/6 TCP RSS when these have not been set. A warning
>     message is thrown to make sure we warn the application we are
>     setting IPv4/6 TCP RSS when not set.
> Why we are enforcing TCP RSS?  I would think it's up to the user to decide what to request based on their specific needs and we should support RSS even when it does not request TCP RSS.
>     - An additional check has been added to dodge RSS configuration
>     altogether unless MQ_RSS has been requested, similar to v3.
>     The alternative (returning error) was considered, the intent
>     is to ease the task of setting up and running vmxnet3 in situations
>     where it's supposted to be most strightforward (testpmd, pktgen).
>     Signed-off-by: Eduard Serra <eserra@vmware.com>
>     ---
> Acked-by: Yong Wang <yongwang@vmware.com>

Sorry I missed your ack here, since it was not quoted patchwork also missed it.

Can you please provide a Fixes tag, that will be useful to backport fix to the
stable trees?


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 16:37 Eduard Serra Miralles
2019-09-13 18:44 ` Yong Wang
2019-09-13 20:10   ` Eduard Serra Miralles
2019-09-16 19:01     ` Yong Wang
2019-10-08 17:55       ` Ferruh Yigit [this message]
2020-03-03 20:44 ` [dpdk-dev] [PATCH v2] " Eduard Serra Miralles
2020-03-04  2:35   ` [dpdk-dev] [PATCH] [v3] " Eduard Serra Miralles
2020-03-05 14:19     ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66a78992-5fc7-191f-9f87-0fe30d0a190a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=eserra@vmware.com \
    --cc=yongwang@vmware.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
	public-inbox-index dev

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/ public-inbox