From: Radu Nicolau <radu.nicolau@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Hari Kumar Vemula <hari.kumarx.vemula@intel.com>,
dev@dpdk.org
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>,
JananeeX M <jananeex.m.parthasarathy@intel.com>,
Declan <declan.doherty@intel.com>,
stable@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave
Date: Wed, 20 Feb 2019 14:56:36 +0000 [thread overview]
Message-ID: <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> (raw)
In-Reply-To: <a8d165a7-d8ef-79ef-e2ae-96ec13e38daf@intel.com>
On 2/20/2019 12:33 PM, Ferruh Yigit wrote:
> On 2/18/2019 3:58 PM, Radu Nicolau wrote:
>>
>> On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote:
>>> test_alb_reply_from_client test fails due to incorrect active slave
>>> array's index. This was due to invalid active slave count.
>>>
>>> Count of internals->active_slave is not updated even when active slave
>>> is deactivated.
>>> Hence active slave count always keeps incrementing beyond the actual
>>> active slaves.
>>>
>>> Fix is to set the internals->active_slave to starting index 0 whenever
>>> it exceeds the number of slaves in active slave list and also update
>>> the active slave count during slave de-activation.
>>>
>>> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
>>> ---
>>>
>> Acked-by: Radu Nicolau <radu.nicolau@intel.com
>> <mailto:radu.nicolau@intel.com>>
> Hi Radu, Hari,
>
> There is another bonding patch, can you please check how related are they and if
> are these fixing same root cause:
>
> net/bonding: avoid the next active slave going out of bound
> https://patches.dpdk.org/patch/49573/
>
Hi, it's a similar fix for the same root cause, but this one covers more
(or all) situations that can cause active_slave to go out of bounds.
next prev parent reply other threads:[~2019-02-20 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <no>
2019-02-18 11:59 ` [dpdk-dev] " Hari Kumar Vemula
2019-02-18 15:58 ` Radu Nicolau
2019-02-20 12:33 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-02-20 14:56 ` Radu Nicolau [this message]
2019-02-20 15:16 ` Hyong Youb Kim
2019-02-22 1:52 ` Chas Williams
2019-02-22 13:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com \
--to=radu.nicolau@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hari.kumarx.vemula@intel.com \
--cc=hyonkim@cisco.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).