From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes
Date: Tue, 16 Jan 2024 14:12:48 +0100 [thread overview]
Message-ID: <6fd88b0f-b043-4a3d-bd64-b0e1ad2f9480@redhat.com> (raw)
In-Reply-To: <20240105211519.185086-5-hernan.vargas@intel.com>
On 1/5/24 22:15, Hernan Vargas wrote:
> Cosmetic changes for comments.
> No functional impact.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 4 +-
> .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 49 ++--
> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 248 +++++++++---------
> .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 16 +-
> 4 files changed, 157 insertions(+), 160 deletions(-)
>
...
>
> @@ -2714,14 +2714,14 @@ vc_5gnr_dequeue_ldpc_dec_one_op_cb(struct fpga_5gnr_queue *q, struct rte_bbdev_d
> union vc_5gnr_dma_desc *desc;
> int desc_error;
>
> - /* Set descriptor */
> + /* Set descriptor. */
> desc = vc_5gnr_get_desc(q, desc_offset);
>
> - /* Verify done bit is set */
> + /* Verify done bit is set. */
> if (desc->dec_req.done == 0)
> return -1;
>
> - /* make sure the response is read atomically */
> + /* make sure the response is read atomically. */
While at it, you could make all comments starting with upper case for
consistency, here and elsewhere in the driver.
prev parent reply other threads:[~2024-01-16 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 21:15 [PATCH v4 0/4] changes for 24.03 Hernan Vargas
2024-01-05 21:15 ` [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Hernan Vargas
2024-01-05 22:00 ` Stephen Hemminger
2024-01-10 17:19 ` Chautru, Nicolas
2024-01-05 21:15 ` [PATCH v4 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant Hernan Vargas
2024-01-15 10:48 ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 3/4] baseband/fpga_5gnr_fec: add AGX100 support Hernan Vargas
2024-01-15 16:59 ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Hernan Vargas
2024-01-05 22:00 ` Stephen Hemminger
2024-01-10 17:17 ` Chautru, Nicolas
2024-01-16 13:12 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd88b0f-b043-4a3d-bd64-b0e1ad2f9480@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).