DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Vargas, Hernan" <hernan.vargas@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"gakhil@marvell.com" <gakhil@marvell.com>,
	 "Rix, Tom" <trix@redhat.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: RE: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes
Date: Wed, 10 Jan 2024 17:17:00 +0000	[thread overview]
Message-ID: <BY5PR11MB4451A3452DB9A0C54DAB1793F8692@BY5PR11MB4451.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240105140058.14b6b08b@hermes.local>

Hi Stephen, 
We got that feedback from a couple of maintainers, so now we adhere to that rule.
In the coding guideline this is not said explicitly but all the examples have periods at the end. So now we just follow that recommendation as gospel.
Possibly it would help to say more explicitly in DPDK coding guidelines what is expected.

Thanks
Nic

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, January 5, 2024 2:01 PM
> To: Vargas, Hernan <hernan.vargas@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; Rix, Tom <trix@redhat.com>;
> maxime.coquelin@redhat.com; Chautru, Nicolas <nicolas.chautru@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment
> changes
> 
> On Fri,  5 Jan 2024 13:15:19 -0800
> Hernan Vargas <hernan.vargas@intel.com> wrote:
> 
> > Cosmetic changes for comments.
> > No functional impact.
> >
> > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> > ---
> 
> This is not helpful, there is no need for periods on every comment sentence.

  reply	other threads:[~2024-01-10 17:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 21:15 [PATCH v4 0/4] changes for 24.03 Hernan Vargas
2024-01-05 21:15 ` [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency Hernan Vargas
2024-01-05 22:00   ` Stephen Hemminger
2024-01-10 17:19     ` Chautru, Nicolas
2024-01-05 21:15 ` [PATCH v4 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant Hernan Vargas
2024-01-15 10:48   ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 3/4] baseband/fpga_5gnr_fec: add AGX100 support Hernan Vargas
2024-01-15 16:59   ` Maxime Coquelin
2024-01-05 21:15 ` [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Hernan Vargas
2024-01-05 22:00   ` Stephen Hemminger
2024-01-10 17:17     ` Chautru, Nicolas [this message]
2024-01-16 13:12   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB4451A3452DB9A0C54DAB1793F8692@BY5PR11MB4451.namprd11.prod.outlook.com \
    --to=nicolas.chautru@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hernan.vargas@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).