* [dpdk-dev] [PATCH] net/i40e: fix VF cannot forward packets issue
@ 2017-11-09 6:30 Xiaoyun Li
2017-11-09 8:33 ` Xing, Beilei
0 siblings, 1 reply; 3+ messages in thread
From: Xiaoyun Li @ 2017-11-09 6:30 UTC (permalink / raw)
To: jingjing.wu, beilei.xing; +Cc: dev, Xiaoyun Li, stable
When Rx interrupt is not enabled, there is no need to check if interrupt
allow others. It will cause VF cannot forwarding packets issue. This patch
fixes this issue.
Fixes: 96a9fd03c25f ("net/i40e: fix Rx queue interrupt mapping in VF")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 02d9e57..91b5bb0 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -650,7 +650,8 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
uint32_t vector_id;
int i, err;
- if (rte_intr_allow_others(intr_handle))
+ if (dev->data->dev_conf.intr_conf.rxq != 0 &&
+ rte_intr_allow_others(intr_handle))
vector_id = I40E_RX_VEC_START;
else
vector_id = I40E_MISC_VEC_ID;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix VF cannot forward packets issue
2017-11-09 6:30 [dpdk-dev] [PATCH] net/i40e: fix VF cannot forward packets issue Xiaoyun Li
@ 2017-11-09 8:33 ` Xing, Beilei
2017-11-10 2:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Xing, Beilei @ 2017-11-09 8:33 UTC (permalink / raw)
To: Li, Xiaoyun, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, November 9, 2017 2:30 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix VF cannot forward packets issue
>
> When Rx interrupt is not enabled, there is no need to check if interrupt allow
> others. It will cause VF cannot forwarding packets issue. This patch fixes this
> issue.
>
> Fixes: 96a9fd03c25f ("net/i40e: fix Rx queue interrupt mapping in VF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 02d9e57..91b5bb0 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -650,7 +650,8 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
> uint32_t vector_id;
> int i, err;
>
> - if (rte_intr_allow_others(intr_handle))
> + if (dev->data->dev_conf.intr_conf.rxq != 0 &&
> + rte_intr_allow_others(intr_handle))
> vector_id = I40E_RX_VEC_START;
> else
> vector_id = I40E_MISC_VEC_ID;
> --
> 2.7.4
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix VF cannot forward packets issue
2017-11-09 8:33 ` Xing, Beilei
@ 2017-11-10 2:15 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-10 2:15 UTC (permalink / raw)
To: Xing, Beilei, Li, Xiaoyun, Wu, Jingjing; +Cc: dev, stable
On 11/9/2017 12:33 AM, Xing, Beilei wrote:
>> -----Original Message-----
>> From: Li, Xiaoyun
>> Sent: Thursday, November 9, 2017 2:30 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
>> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
>> Subject: [PATCH] net/i40e: fix VF cannot forward packets issue
>>
>> When Rx interrupt is not enabled, there is no need to check if interrupt allow
>> others. It will cause VF cannot forwarding packets issue. This patch fixes this
>> issue.
>>
>> Fixes: 96a9fd03c25f ("net/i40e: fix Rx queue interrupt mapping in VF")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-10 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 6:30 [dpdk-dev] [PATCH] net/i40e: fix VF cannot forward packets issue Xiaoyun Li
2017-11-09 8:33 ` Xing, Beilei
2017-11-10 2:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).