From: Kevin Traynor <ktraynor@redhat.com>
To: Mesut Ali Ergin <mesut.a.ergin@intel.com>,
beilei.xing@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action
Date: Thu, 6 Jun 2019 20:58:11 +0100 [thread overview]
Message-ID: <78d4b3a8-fc34-5dc1-85aa-2f31a8af2acf@redhat.com> (raw)
In-Reply-To: <1559838642-125443-1-git-send-email-mesut.a.ergin@intel.com>
On 06/06/2019 17:30, Mesut Ali Ergin wrote:
> Initializes mark_spec pointer to NULL.
>
> Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action")
> Coverity issue: 341075
>
> Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 9bfbea2..d62b32f 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -3052,7 +3052,7 @@ i40e_flow_parse_fdir_action(struct rte_eth_dev *dev,
> struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> const struct rte_flow_action *act;
> const struct rte_flow_action_queue *act_q;
> - const struct rte_flow_action_mark *mark_spec;
> + const struct rte_flow_action_mark *mark_spec = NULL;
> uint32_t index = 0;
>
> /* Check if the first non-void action is QUEUE or DROP or PASSTHRU. */
>
next prev parent reply other threads:[~2019-06-06 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 16:30 Mesut Ali Ergin
2019-06-06 19:58 ` Kevin Traynor [this message]
2019-06-06 22:13 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d4b3a8-fc34-5dc1-85aa-2f31a8af2acf@redhat.com \
--to=ktraynor@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=mesut.a.ergin@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).