From: Alfredo Cardigliano <cardigliano@ntop.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions
Date: Fri, 3 Jan 2020 09:22:20 +0100 [thread overview]
Message-ID: <805A07B7-E29C-4451-9EE6-2DDD6F56AC2D@ntop.org> (raw)
In-Reply-To: <20191219161645.7309a690@hermes.lan>
> On 20 Dec 2019, at 01:16, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> On Thu, 19 Dec 2019 23:18:32 +0100
> Alfredo Cardigliano <cardigliano@ntop.org> wrote:
>
>> +
>> +#pragma pack(push, 1)
>> +
>
> Really, packing leads to unaligned data structures and is generally
> a bad idea.
This specific file defines data structures shared with the adapter (and other OS drivers)
thus any additional padding should be avoided. Actually the pragma is unnecessary
here, as who wrote this file worked pretty hard tweaking the structs by hand to be sure
that they are all formed such that the fields are on their appropriate byte boundaries
and all field padding is explicitly defined.
Alfredo
next prev parent reply other threads:[~2020-01-03 8:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 22:18 [dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 01/17] net/ionic: add skeleton Alfredo Cardigliano
2020-01-07 16:34 ` Ferruh Yigit
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano
2019-12-20 0:16 ` Stephen Hemminger
2020-01-03 8:22 ` Alfredo Cardigliano [this message]
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 03/17] net/ionic: add log Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano
2019-12-20 0:19 ` Stephen Hemminger
2019-12-20 0:23 ` Stephen Hemminger
2019-12-20 0:24 ` Stephen Hemminger
2019-12-20 0:27 ` Stephen Hemminger
2020-01-07 16:35 ` Ferruh Yigit
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 05/17] net/ionic: add port management commands Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support Alfredo Cardigliano
2019-12-20 1:12 ` Stephen Hemminger
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 07/17] net/ionic: add doorbells Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 08/17] net/ionic: add adminq support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 09/17] net/ionic: add notifyq support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 10/17] net/ionic: add basic port operations Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 11/17] net/ionic: add RX filters support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 12/17] net/ionic: add Flow Control support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 13/17] net/ionic: add RX and TX handling Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 14/17] net/ionic: add RSS support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 15/17] net/ionic: add stats Alfredo Cardigliano
2019-12-20 0:28 ` Stephen Hemminger
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 16/17] net/ionic: add TX checksum support Alfredo Cardigliano
2019-12-19 22:18 ` [dpdk-dev] [PATCH v4 17/17] net/ionic: read fw version Alfredo Cardigliano
2020-01-07 16:34 ` [dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805A07B7-E29C-4451-9EE6-2DDD6F56AC2D@ntop.org \
--to=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).