From: David Christensen <drc@linux.vnet.ibm.com>
To: thomas@monjalon.net, Ruifeng Wang <ruifeng.wang@arm.com>,
Min Zhou <zhoumin@loongson.cn>,
Stanislaw Kardach <kda@semihalf.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] eal/linux: eal/linux: verify mmu type for DPDK support (ppc64le)
Date: Mon, 23 Oct 2023 19:02:52 -0700 [thread overview]
Message-ID: <85f828e2-6880-0619-a829-4e139ce9ac73@linux.vnet.ibm.com> (raw)
In-Reply-To: <20231023231939.188417-1-drc@linux.vnet.ibm.com>
On 10/23/23 4:19 PM, David Christensen wrote:
> diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
> index ebd496b537cf..7d84adb5b328 100644
> --- a/lib/eal/common/eal_private.h
> +++ b/lib/eal/common/eal_private.h
> @@ -354,6 +354,13 @@ unsigned eal_cpu_core_id(unsigned lcore_id);
> */
> int eal_cpu_detected(unsigned lcore_id);
>
> +/**
> + * Check for architecture supported MMU.
> + *
> + * This function is private to the EAL.
> + */
> +bool eal_mmu_supported_arch(void);
> +
...
> diff --git a/lib/eal/ppc/rte_mmu.c b/lib/eal/ppc/rte_mmu.c
> new file mode 100644
> index 000000000000..017a8768bce3
> --- /dev/null
> +++ b/lib/eal/ppc/rte_mmu.c
> @@ -0,0 +1,53 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (C) IBM Corporation 2023
> + */
> +
> +#include "rte_log.h"
> +#include "eal_private.h"
> +
> +bool
> +eal_mmu_supported_arch(void)
> +{
> + static const char proc_cpuinfo[] = "/proc/cpuinfo";
Belatedly recognized that I'd implemented an OS specific detection
mechanism for a function in the "common" library. I'll resubmit a v3
under the "linux" subtree shortly.
Dave
next prev parent reply other threads:[~2023-10-24 2:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 22:51 [PATCH] " David Christensen
2023-10-17 12:39 ` Thomas Monjalon
2023-10-23 21:59 ` David Christensen
2023-11-06 13:54 ` Thomas Monjalon
2023-10-23 23:19 ` [PATCH v2] eal/linux: " David Christensen
2023-10-24 2:02 ` David Christensen [this message]
2023-10-24 17:43 ` [PATCH v3] " David Christensen
2023-11-06 13:55 ` Thomas Monjalon
2023-11-30 19:18 ` [PATCH v4] eal: " David Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f828e2-6880-0619-a829-4e139ce9ac73@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kda@semihalf.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).