Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

[Heinrich Kuhn <heinrich.kuhn@netronome.com>]

On 2021/07/23 16:14, Thomas Monjalon wrote:
> Please review.
> 
> 28/06/2021 13:13, Andrew Rybchenko:
>> Hi Heinrich,
>>
>> could you take a look at the patch?
>>
>> Thanks,
>> Andrew.
>>
>> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
>>> Logging should be converted to dynamic log.
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>>>   1 file changed, 7 deletions(-)
>>>
>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
>>> index 27dd87611b94..76cc94cb6565 100644
>>> --- a/drivers/net/nfp/nfp_net_logs.h
>>> +++ b/drivers/net/nfp/nfp_net_logs.h
>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>>>   #define ASSERT(x) do { } while (0)
>>>   #endif
>>>   
>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -
>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -#define PMD_CPP_LOG(level, fmt, args...) \
>>> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
>>> -#else
>>>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>> -#endif
>>>   
>>>   extern int nfp_logtype_driver;
>>>   #define PMD_DRV_LOG(level, fmt, args...) \
> 
> 
> 
Hi Andrew,

Apologies for the delay, looks good thanks

Reviewed-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>