[dpdk-dev] [PATCH] doc: release note for the IPsec library

[dpdk-dev] [PATCH] doc: release note for the IPsec library

[Bernard Iremonger]

Update release notes for changes to the IPsec library.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 doc/guides/rel_notes/release_19_08.rst | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index c9bd3ce..020a8ed 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -224,6 +224,20 @@ New Features
 
   Added multiple cores feature to compression perf tool application.
 
+* **Updated the IPsec library.**
+
+  Added missing functionality for IPsec RFC's (4301, 403, 7321) compliance.
+
+  * Added support for transport mode with IPv6 extension headers.
+
+  * Added support for SA lifetime (soft/hard limit bytes/time).
+
+  * Expanded IV generation code to make it complain with particular algorithm
+    requirements (CBC, GCM, etc.).
+
+  * Added support for RFC 4301, section 5.1.2. Header Construction for Tunnel
+    Mode.
+
 
 Removed Items
 -------------
@@ -384,7 +398,7 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_gso.so.1
      librte_hash.so.2
      librte_ip_frag.so.1
-     librte_ipsec.so.1
+   + librte_ipsec.so.1
      librte_jobstats.so.1
      librte_kni.so.2
      librte_kvargs.so.1
-- 
2.7.4

[dpdk-dev] [PATCH v2] doc: release note for the IPsec library

[Bernard Iremonger]

Update release notes for changes to the IPsec library.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
changes in v2:
revised content.

 doc/guides/rel_notes/release_19_08.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index c9bd3ce..35b633e 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -224,6 +224,14 @@ New Features
 
   Added multiple cores feature to compression perf tool application.
 
+* **Updated the IPsec library.**
+
+  Added missing functionality to ``librte_ipsec``.
+
+  * Added support for transport mode with IPv6 extension headers.
+
+  * Added support for packets that consist of multiple segments.
+
 
 Removed Items
 -------------
-- 
2.7.4

[dpdk-dev] [PATCH v3] doc: release note for the IPsec library

[Bernard Iremonger]

Update release notes for changes to the IPsec library.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
changes in v3:
revised content

 doc/guides/rel_notes/release_19_08.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index c9bd3ce..7737ebe 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -224,6 +224,14 @@ New Features
 
   Added multiple cores feature to compression perf tool application.
 
+* **Updated the IPsec library.**
+
+  Added the following functionality to ``librte_ipsec``.
+
+  * Added support for transport mode with IPv6 extension headers.
+
+  * Added support for packets that consist of multiple segments.
+
 
 Removed Items
 -------------
-- 
2.7.4

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

[Ananyev, Konstantin]

> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Thursday, July 25, 2019 3:39 PM
> To: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; akhil.goyal@nxp.com; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH v3] doc: release note for the IPsec library
> 
> Update release notes for changes to the IPsec library.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> changes in v3:
> revised content
> 
>  doc/guides/rel_notes/release_19_08.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
> index c9bd3ce..7737ebe 100644
> --- a/doc/guides/rel_notes/release_19_08.rst
> +++ b/doc/guides/rel_notes/release_19_08.rst
> @@ -224,6 +224,14 @@ New Features
> 
>    Added multiple cores feature to compression perf tool application.
> 
> +* **Updated the IPsec library.**
> +
> +  Added the following functionality to ``librte_ipsec``.
> +
> +  * Added support for transport mode with IPv6 extension headers.
> +
> +  * Added support for packets that consist of multiple segments.
> +
> 
>  Removed Items
>  -------------
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.7.4

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

[Akhil Goyal]

Hi Bernard,

> 
> Update release notes for changes to the IPsec library.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> changes in v3:
> revised content
> 
>  doc/guides/rel_notes/release_19_08.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_08.rst
> b/doc/guides/rel_notes/release_19_08.rst
> index c9bd3ce..7737ebe 100644
> --- a/doc/guides/rel_notes/release_19_08.rst
> +++ b/doc/guides/rel_notes/release_19_08.rst
> @@ -224,6 +224,14 @@ New Features
> 
>    Added multiple cores feature to compression perf tool application.
> 
> +* **Updated the IPsec library.**
> +
> +  Added the following functionality to ``librte_ipsec``.
> +
> +  * Added support for transport mode with IPv6 extension headers.
> +
> +  * Added support for packets that consist of multiple segments.
> +
> 

Ipsec library changes are already there in the release note.
Could you please consolidate all changes in ipsec lib in a single bullet.

Also the ipsec-secgw application changes can also be there in that single bullet. As the features are same for ipsec lib and ipsec application.

So I would say, we can combine the two commits in a single bullet already there in the release note for header reconstruction.
http://patches.dpdk.org/patch/57122/
http://patches.dpdk.org/patch/57124/


-Akhil

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

[Iremonger, Bernard]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, July 26, 2019 11:27 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: RE: [PATCH v3] doc: release note for the IPsec library
> 
> Hi Bernard,
> 
> >
> > Update release notes for changes to the IPsec library.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > changes in v3:
> > revised content
> >
> >  doc/guides/rel_notes/release_19_08.rst | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_19_08.rst
> > b/doc/guides/rel_notes/release_19_08.rst
> > index c9bd3ce..7737ebe 100644
> > --- a/doc/guides/rel_notes/release_19_08.rst
> > +++ b/doc/guides/rel_notes/release_19_08.rst
> > @@ -224,6 +224,14 @@ New Features
> >
> >    Added multiple cores feature to compression perf tool application.
> >
> > +* **Updated the IPsec library.**
> > +
> > +  Added the following functionality to ``librte_ipsec``.
> > +
> > +  * Added support for transport mode with IPv6 extension headers.
> > +
> > +  * Added support for packets that consist of multiple segments.
> > +
> >
> 
> Ipsec library changes are already there in the release note.
> Could you please consolidate all changes in ipsec lib in a single bullet.
> 
> Also the ipsec-secgw application changes can also be there in that single
> bullet. As the features are same for ipsec lib and ipsec application.
> 
> So I would say, we can combine the two commits in a single bullet already
> there in the release note for header reconstruction.
> http://patches.dpdk.org/patch/57122/
> http://patches.dpdk.org/patch/57124/
> 
> 
> -Akhil

I will update existing bullet with info in patches 57122 and 57124.

Regards,

Bernard.

[dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

[Bernard Iremonger]

Update release notes for changes to the IPsec library.
Update release notes for changes to the IPsec Security Gateway application

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 doc/guides/rel_notes/release_19_08.rst | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index c9bd3ce..48319be 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -200,11 +200,20 @@ New Features
   handshake between two separate hosts and can share local memory for peer
   host to directly access.
 
-* **Updated IPSec library Header Reconstruction.**
+* **Updated IPSec library and IPsec Security Gateway application.**
 
-  Updated the IPSec library with ECN and DSCP field header reconstruction
-  feature followed by RFC4301. The IPSec-secgw sample application is also
-  updated to support this feature by default.
+  Added the following functionality to ``librte_ipsec`` and ``ipsec-secgw``
+
+  * Updated ``librte_ipsec`` with ECN and DSCP field header reconstruction
+    feature followed by RFC4301.
+
+  * Added support for transport mode with IPv6 extension headers to
+    ``librte_ipsec``.
+
+  * Added support for packets that consist of multiple segments to
+    ``librte_ipsec``.
+
+  * Updated the ``ipsec-secgw`` sample application to support these features.
 
 * **Updated telemetry library for global metrics support.**
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

[Akhil Goyal]

> 
> Update release notes for changes to the IPsec library.
> Update release notes for changes to the IPsec Security Gateway application

Description and the release note updates use redundant words which can be avoided.
It could be something like

"Update release notes for recently supported features in ipsec lib and application."

> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/rel_notes/release_19_08.rst | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_19_08.rst
> b/doc/guides/rel_notes/release_19_08.rst
> index c9bd3ce..48319be 100644
> --- a/doc/guides/rel_notes/release_19_08.rst
> +++ b/doc/guides/rel_notes/release_19_08.rst
> @@ -200,11 +200,20 @@ New Features
>    handshake between two separate hosts and can share local memory for peer
>    host to directly access.
> 
> -* **Updated IPSec library Header Reconstruction.**
> +* **Updated IPSec library and IPsec Security Gateway application.**
> 
> -  Updated the IPSec library with ECN and DSCP field header reconstruction
> -  feature followed by RFC4301. The IPSec-secgw sample application is also
> -  updated to support this feature by default.
> +  Added the following functionality to ``librte_ipsec`` and ``ipsec-secgw``

Added following features to ``librte_ipsec``. Corresponding changes are also added in ``ipsec-secgw`` sample application.
> +
> +  * Updated ``librte_ipsec`` with ECN and DSCP field header reconstruction
> +    feature followed by RFC4301.

* ECN and DSCP field header reconstruction as per RFC4301

> +
> +  * Added support for transport mode with IPv6 extension headers to
> +    ``librte_ipsec``.

*  Transport mode with IPv6 extension headers

> +
> +  * Added support for packets that consist of multiple segments to
> +    ``librte_ipsec``.

* Support packets with multiple segments.

> +

> +  * Updated the ``ipsec-secgw`` sample application to support these features.

This bullet can be removed.
> 
>  * **Updated telemetry library for global metrics support.**
> 

-Akhil

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

[Iremonger, Bernard]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, July 26, 2019 1:36 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: RE: [PATCH v4] doc: release note for the IPsec library and application
> 
> 
> >
> > Update release notes for changes to the IPsec library.
> > Update release notes for changes to the IPsec Security Gateway
> application
> 
> Description and the release note updates use redundant words which can be
> avoided.
> It could be something like
> 
> "Update release notes for recently supported features in ipsec lib and
> application."

Ok, will change.

> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> >  doc/guides/rel_notes/release_19_08.rst | 17 +++++++++++++----
> >  1 file changed, 13 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_19_08.rst
> > b/doc/guides/rel_notes/release_19_08.rst
> > index c9bd3ce..48319be 100644
> > --- a/doc/guides/rel_notes/release_19_08.rst
> > +++ b/doc/guides/rel_notes/release_19_08.rst
> > @@ -200,11 +200,20 @@ New Features
> >    handshake between two separate hosts and can share local memory for
> peer
> >    host to directly access.
> >
> > -* **Updated IPSec library Header Reconstruction.**
> > +* **Updated IPSec library and IPsec Security Gateway application.**
> >
> > -  Updated the IPSec library with ECN and DSCP field header reconstruction
> > -  feature followed by RFC4301. The IPSec-secgw sample application is also
> > -  updated to support this feature by default.
> > +  Added the following functionality to ``librte_ipsec`` and ``ipsec-secgw``
> 
> Added following features to ``librte_ipsec``. Corresponding changes are also
> added in ``ipsec-secgw`` sample application.

Ok, will change.

> > +
> > +  * Updated ``librte_ipsec`` with ECN and DSCP field header reconstruction
> > +    feature followed by RFC4301.
> 
> * ECN and DSCP field header reconstruction as per RFC4301
> 
> > +
> > +  * Added support for transport mode with IPv6 extension headers to
> > +    ``librte_ipsec``.
> 
> *  Transport mode with IPv6 extension headers

Ok, will change
 
> > +
> > +  * Added support for packets that consist of multiple segments to
> > +    ``librte_ipsec``.
> 
> * Support packets with multiple segments.
> 

Ok, will change.

> > +
> 
> > +  * Updated the ``ipsec-secgw`` sample application to support these
> features.
> 
> This bullet can be removed.

Ok, will remove.

> >
> >  * **Updated telemetry library for global metrics support.**
> >
> 
> -Akhil

Regards,

Bernard.

[dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

[Bernard Iremonger]

Update release notes for recently supported features in IPsec library and
IPsec Security Gateway application.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 doc/guides/rel_notes/release_19_08.rst | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst
index c9bd3ce..0457ab2 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -200,11 +200,16 @@ New Features
   handshake between two separate hosts and can share local memory for peer
   host to directly access.
 
-* **Updated IPSec library Header Reconstruction.**
+* **Updated IPSec library and IPsec Security Gateway application.**
 
-  Updated the IPSec library with ECN and DSCP field header reconstruction
-  feature followed by RFC4301. The IPSec-secgw sample application is also
-  updated to support this feature by default.
+  Added the following features to ``librte_ipsec``. Corresponding changes are
+  also added in ``ipsec-secgw`` sample application
+
+  * ECN and DSCP field header reconstruction as per RFC4301.
+
+  * Transport mode with IPv6 extension headers.
+
+  * Support packets with multiple segments.
 
 * **Updated telemetry library for global metrics support.**
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

[Akhil Goyal]

> 
> Update release notes for recently supported features in IPsec library and
> IPsec Security Gateway application.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/rel_notes/release_19_08.rst | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

[Akhil Goyal]

> >
> > Update release notes for recently supported features in IPsec library and
> > IPsec Security Gateway application.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> >  doc/guides/rel_notes/release_19_08.rst | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.