* [dpdk-dev] [PATCH v2] vhost: read last used index once
@ 2021-04-07 9:51 Balazs Nemeth
2021-04-07 9:55 ` [dpdk-dev] [PATCH v3] " Balazs Nemeth
0 siblings, 1 reply; 2+ messages in thread
From: Balazs Nemeth @ 2021-04-07 9:51 UTC (permalink / raw)
To: bnemeth, dev
Instead of calculating the address of a packed descriptor based on the
vq->desc_packed and vq->last_used_idx every time, store that base
address in desc_base. On arm, this saves 176 bytes in code size of
function in which vhost_flush_enqueue_batch_packed gets inlined.
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
---
lib/librte_vhost/virtio_net.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 179c57b46..f091384a6 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -217,6 +217,8 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev,
{
uint16_t i;
uint16_t flags;
+ uint16_t last_used_idx = vq->last_used_idx;
+ struct vring_packed_desc *desc_base = &vq->desc_packed[last_used_idx];
if (vq->shadow_used_idx) {
do_data_copy_enqueue(dev, vq);
@@ -226,16 +228,17 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev,
flags = PACKED_DESC_ENQUEUE_USED_FLAG(vq->used_wrap_counter);
vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
- vq->desc_packed[vq->last_used_idx + i].id = ids[i];
- vq->desc_packed[vq->last_used_idx + i].len = lens[i];
+ desc_base[i].id = ids[i];
+ desc_base[i].len = lens[i];
}
rte_atomic_thread_fence(__ATOMIC_RELEASE);
- vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
- vq->desc_packed[vq->last_used_idx + i].flags = flags;
+ vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
+ desc_base[i].flags = flags;
+ }
- vhost_log_cache_used_vring(dev, vq, vq->last_used_idx *
+ vhost_log_cache_used_vring(dev, vq, last_used_idx *
sizeof(struct vring_packed_desc),
sizeof(struct vring_packed_desc) *
PACKED_BATCH_SIZE);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-dev] [PATCH v3] vhost: read last used index once
2021-04-07 9:51 [dpdk-dev] [PATCH v2] vhost: read last used index once Balazs Nemeth
@ 2021-04-07 9:55 ` Balazs Nemeth
0 siblings, 0 replies; 2+ messages in thread
From: Balazs Nemeth @ 2021-04-07 9:55 UTC (permalink / raw)
To: bnemeth, dev
Instead of calculating the address of a packed descriptor based on the
vq->desc_packed and vq->last_used_idx every time, store that base
address in desc_base. On arm, this saves 176 bytes in code size of
function in which vhost_flush_enqueue_batch_packed gets inlined.
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
---
lib/librte_vhost/virtio_net.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 179c57b46..f091384a6 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -217,6 +217,8 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev,
{
uint16_t i;
uint16_t flags;
+ uint16_t last_used_idx = vq->last_used_idx;
+ struct vring_packed_desc *desc_base = &vq->desc_packed[last_used_idx];
if (vq->shadow_used_idx) {
do_data_copy_enqueue(dev, vq);
@@ -226,16 +228,17 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev,
flags = PACKED_DESC_ENQUEUE_USED_FLAG(vq->used_wrap_counter);
vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
- vq->desc_packed[vq->last_used_idx + i].id = ids[i];
- vq->desc_packed[vq->last_used_idx + i].len = lens[i];
+ desc_base[i].id = ids[i];
+ desc_base[i].len = lens[i];
}
rte_atomic_thread_fence(__ATOMIC_RELEASE);
- vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
- vq->desc_packed[vq->last_used_idx + i].flags = flags;
+ vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
+ desc_base[i].flags = flags;
+ }
- vhost_log_cache_used_vring(dev, vq, vq->last_used_idx *
+ vhost_log_cache_used_vring(dev, vq, last_used_idx *
sizeof(struct vring_packed_desc),
sizeof(struct vring_packed_desc) *
PACKED_BATCH_SIZE);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-07 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 9:51 [dpdk-dev] [PATCH v2] vhost: read last used index once Balazs Nemeth
2021-04-07 9:55 ` [dpdk-dev] [PATCH v3] " Balazs Nemeth
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git