From: Jie Hai <haijie1@huawei.com>
To: Ali Alnubani <alialnu@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Shiyang He <shiyangx.he@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"liudongdong3@huawei.com" <liudongdong3@huawei.com>
Subject: Re: [PATCH] app/testpmd: fix invalid queue ID when start port
Date: Tue, 4 Jul 2023 10:01:32 +0800 [thread overview]
Message-ID: <8e6bcefc-2239-d8c0-060b-9e8f31f86e1d@huawei.com> (raw)
In-Reply-To: <DM4PR12MB516705109D03A844E81C2682DA29A@DM4PR12MB5167.namprd12.prod.outlook.com>
On 2023/7/3 20:33, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Jie Hai <haijie1@huawei.com>
>> Sent: Monday, July 3, 2023 2:03 PM
>> To: Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
>> <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Shiyang He
>> <shiyangx.he@intel.com>
>> Cc: dev@dpdk.org; liudongdong3@huawei.com; Ali Alnubani
>> <alialnu@nvidia.com>
>> Subject: [PATCH] app/testpmd: fix invalid queue ID when start port
>>
>> Function update_queue_state updates queue state of all queues
>> of all ports, using the queue num nb_rxq|nb_txq stored locally
>> by testpmd. Error on invalid queue ID occurs if we start testpmd
>> with two ports and detach-attach one of them and start the other
>> port first. That's because the attached port has zero queues and
>> that differs from the nb_rxq|nb_txq. The similar error happens
>> in multi-process senoris if secondary process attaches a port
>
> Do you mean scenarios?
Yes, sorry for the spelling mistake. I'll correct it.
>
>> and starts it.
>>
>> This patch updates queue state according to the num of queues
>> reported by driver instead of testpmd.
>>
>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all
>> queues")
>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet
>> forwarding")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>> ---
>
> Thanks Jie.
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
next prev parent reply other threads:[~2023-07-04 2:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:02 Jie Hai
2023-07-03 12:33 ` Ali Alnubani
2023-07-04 2:01 ` Jie Hai [this message]
2023-07-04 2:22 ` lihuisong (C)
2023-07-04 8:45 ` [PATCH v2] " Jie Hai
2023-07-04 9:16 ` Ali Alnubani
2023-07-04 9:42 ` fengchengwen
2023-07-04 10:59 ` Ferruh Yigit
2023-07-05 3:16 ` lihuisong (C)
2023-07-05 8:02 ` Ferruh Yigit
2023-07-05 8:07 ` Ferruh Yigit
2023-07-05 9:40 ` lihuisong (C)
2023-07-05 11:41 ` Ferruh Yigit
2023-07-06 2:48 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e6bcefc-2239-d8c0-060b-9e8f31f86e1d@huawei.com \
--to=haijie1@huawei.com \
--cc=alialnu@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=liudongdong3@huawei.com \
--cc=shiyangx.he@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).