DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: change license to BSD-3-Clause
Date: Tue, 9 Jan 2018 22:59:40 +0300	[thread overview]
Message-ID: <8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com> (raw)
In-Reply-To: <cc8fc312-e581-1893-8ba6-88e20d17e55a@intel.com>

On 01/09/2018 10:38 PM, Ferruh Yigit wrote:
> On 1/8/2018 1:35 PM, Andrew Rybchenko wrote:
>> Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause.
>> Bump copyright year.
>>
> <...>
>
>> @@ -1,28 +1,8 @@
>> +   SPDX-License-Identifier: BSD-3-Clause
>>   
>> -   Copyright (c) 2006-2016 Solarflare Communications Inc.
>> +   Copyright (c) 2006-2018 Solarflare Communications Inc.
>>      All rights reserved.
> Defined syntax has no empty line between SPDX and Copyright line, is that line
> intentionally left?

Yes. I've seen examples, but have not found exact requirement to have
no empty line. We have file with 2 copyright holders and it looks strange
in this case without empty line.

> And not sure if this cause any problem on scripting license checks in the future...

Of course this empty line is not that critical and I can remove it if 
required.

> <...>

  reply	other threads:[~2018-01-09 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 13:35 Andrew Rybchenko
2018-01-08 13:35 ` [dpdk-dev] [PATCH 2/2] net/sfc: " Andrew Rybchenko
2018-01-09  8:03   ` Hemant Agrawal
2018-01-09  8:04 ` [dpdk-dev] [PATCH 1/2] net/sfc/base: " Hemant Agrawal
2018-01-09 19:38 ` Ferruh Yigit
2018-01-09 19:59   ` Andrew Rybchenko [this message]
2018-01-10 10:23     ` Bruce Richardson
2018-01-10 10:38       ` Hemant Agrawal
2018-01-10 19:42 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).