From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: change license to BSD-3-Clause
Date: Wed, 10 Jan 2018 10:23:41 +0000 [thread overview]
Message-ID: <20180110102341.GC6388@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com>
On Tue, Jan 09, 2018 at 10:59:40PM +0300, Andrew Rybchenko wrote:
> On 01/09/2018 10:38 PM, Ferruh Yigit wrote:
> > On 1/8/2018 1:35 PM, Andrew Rybchenko wrote:
> > > Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause.
> > > Bump copyright year.
> > >
> > <...>
> >
> > > @@ -1,28 +1,8 @@
> > > + SPDX-License-Identifier: BSD-3-Clause
> > > - Copyright (c) 2006-2016 Solarflare Communications Inc.
> > > + Copyright (c) 2006-2018 Solarflare Communications Inc.
> > > All rights reserved.
> > Defined syntax has no empty line between SPDX and Copyright line, is that line
> > intentionally left?
>
> Yes. I've seen examples, but have not found exact requirement to have
> no empty line. We have file with 2 copyright holders and it looks strange
> in this case without empty line.
>
As far as I know, the format for headers is fully spec'ed, except that
it is optional to have blank line after the SPDX tag. Either is allowed,
and it's not likely to have major scripting implications. I think most
of us prefer to not have the line, but it's not prohibited.
/Bruce
next prev parent reply other threads:[~2018-01-10 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 13:35 Andrew Rybchenko
2018-01-08 13:35 ` [dpdk-dev] [PATCH 2/2] net/sfc: " Andrew Rybchenko
2018-01-09 8:03 ` Hemant Agrawal
2018-01-09 8:04 ` [dpdk-dev] [PATCH 1/2] net/sfc/base: " Hemant Agrawal
2018-01-09 19:38 ` Ferruh Yigit
2018-01-09 19:59 ` Andrew Rybchenko
2018-01-10 10:23 ` Bruce Richardson [this message]
2018-01-10 10:38 ` Hemant Agrawal
2018-01-10 19:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110102341.GC6388@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).