RE: [PATCH v3 26/33] net/ena: cosmetic changes

["Brandes, Shai" <shaibran@amazon.com>]

[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]

Thanks Ferruh, we will fix and upload a new patchset

בתאריך 8 במרץ 2024 13:18,‏ Ferruh Yigit <ferruh.yigit@amd.com> כתב:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> This patch makes several changes to improve
> the style and readability of the code.
>
> Signed-off-by: Shai Brandes <shaibran@amazon.com>
> Reviewed-by: Amit Bernstein <amitbern@amazon.com>
> ---
>  drivers/net/ena/hal/ena_com.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c
> index b98540ba63..2db21e7895 100644
> --- a/drivers/net/ena/hal/ena_com.c
> +++ b/drivers/net/ena/hal/ena_com.c
> @@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp)
>
>               /* PHC is in active state, update statistics according to req_id and error_flags */
>               if ((READ_ONCE16(read_resp->req_id) != phc->req_id) ||
> -                 (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) {
> +                 (read_resp->error_flags & ENA_PHC_ERROR_FLAGS))
>                       /* Device didn't update req_id during blocking time or timestamp is invalid,
>                        * this indicates on a device error
>                        */
>                       phc->stats.phc_err++;
> -             } else {
> +             else
>                       /* Device updated req_id during blocking time with valid timestamp */
>                       phc->stats.phc_exp++;
> -             }
>       }
>
>       /* Setting relative timeouts */
> @@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *ena_dev, void *data)
>               timestamp = (u64)aenq_common->timestamp_low |
>                       ((u64)aenq_common->timestamp_high << 32);
>
> -             ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIU64 "s]\n",
> +             ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIu64 "s]\n",
>

'ENA_PRIu64' is not defined yet in this patch, so patch by patch build
fails.


[-- Attachment #2: Type: text/html, Size: 4911 bytes --]