[PATCH] build: make ring mempool driver mandatory

[PATCH] build: make ring mempool driver mandatory

[Bruce Richardson]

The default mempool driver is one based on the rte_ring, and as such it
needs to be present to have just about any app (which doesn't override
the mempool) run. Given this state of affairs it is probably best to add
this default mempool driver to the always-enabled list to ensure we get
a runnable build in all cases. This means that, for example, to run some
NIC tests with testpmd in a minimal build, in most cases, all the user
should need to do is specify "-Denable_drivers=net/<nic_drv>" for the
build.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/meson.build | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/meson.build b/drivers/meson.build
index d5f4e1c1f2..1d8123b00c 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -40,6 +40,8 @@ endif
 
 # these drivers must always be enabled, otherwise the build breaks
 always_enable = ['bus/pci', 'bus/vdev']
+# we always need a mempool driver, and ring is default, so make it mandatory
+always_enable += ['mempool/ring']
 enable_drivers += always_enable
 
 default_cflags = machine_args
-- 
2.32.0

RE: [PATCH] build: make ring mempool driver mandatory

[Morten Brørup]

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Monday, 14 February 2022 16.31
> 
> The default mempool driver is one based on the rte_ring, and as such it
> needs to be present to have just about any app (which doesn't override
> the mempool) run. Given this state of affairs it is probably best to
> add
> this default mempool driver to the always-enabled list to ensure we get
> a runnable build in all cases. This means that, for example, to run
> some
> NIC tests with testpmd in a minimal build, in most cases, all the user
> should need to do is specify "-Denable_drivers=net/<nic_drv>" for the
> build.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/meson.build b/drivers/meson.build
> index d5f4e1c1f2..1d8123b00c 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -40,6 +40,8 @@ endif
> 
>  # these drivers must always be enabled, otherwise the build breaks
>  always_enable = ['bus/pci', 'bus/vdev']
> +# we always need a mempool driver, and ring is default, so make it
> mandatory
> +always_enable += ['mempool/ring']
>  enable_drivers += always_enable
> 
>  default_cflags = machine_args
> --
> 2.32.0
> 

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] build: make ring mempool driver mandatory

[Thomas Monjalon]

15/02/2022 10:25, Morten Brørup:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Monday, 14 February 2022 16.31
> > 
> > The default mempool driver is one based on the rte_ring, and as such it
> > needs to be present to have just about any app (which doesn't override
> > the mempool) run. Given this state of affairs it is probably best to
> > add
> > this default mempool driver to the always-enabled list to ensure we get
> > a runnable build in all cases. This means that, for example, to run
> > some
> > NIC tests with testpmd in a minimal build, in most cases, all the user
> > should need to do is specify "-Denable_drivers=net/<nic_drv>" for the
> > build.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>

Applied, thanks.