RE: [PATCH 3/8] vmxnet3: add rx queue usage count utility

["Morten Brørup" <mb@smartsharesystems.com>]

> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
> Sent: Wednesday, 4 May 2022 16.28
> 
> rx -> Rx
> 
> in summary in accordance with spelling in DPDK
> 
> On 5/3/22 07:22, Pankaj Gupta wrote:
> > Count the number of entries in the rx queue for debugging.
> 
> rx -> Rx
> 
> As I understand debugging is not the only purpose of the API.

Correct. E.g. our appliance uses it in the production data plane, not just for debugging. We only need the function to return an approximate number, though.

> 
> >
> > Tested, using testpmd, for different hardware version on ESXi 7.0
> Update 2
> >
> > Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
> > ---
> >   drivers/net/vmxnet3/vmxnet3_ethdev.c |  1 +
> >   drivers/net/vmxnet3/vmxnet3_ethdev.h |  3 +++
> >   drivers/net/vmxnet3/vmxnet3_rxtx.c   | 30
> ++++++++++++++++++++++++++++
> >   3 files changed, 34 insertions(+)
> >
> > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > index eb65499cf2..a76796716b 100644
> > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > @@ -294,6 +294,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
> >   	eth_dev->rx_pkt_burst = &vmxnet3_recv_pkts;
> >   	eth_dev->tx_pkt_burst = &vmxnet3_xmit_pkts;
> >   	eth_dev->tx_pkt_prepare = vmxnet3_prep_pkts;
> > +	eth_dev->rx_queue_count = vmxnet3_dev_rx_queue_count,
> 
> Please, put it just after rx_pkt_burst to preserve the same order as in
> structure.
> 
> >   	pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> >
> >   	/* extra mbuf field is required to guess MSS */
> 
> [snip]