From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
Date: Mon, 8 Jan 2018 01:53:07 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07C94DC9@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E71ACE5DC6@SHSMSX103.ccr.corp.intel.com>
Yes, I will commit a new version today.
> -----Original Message-----
> From: Zhang, Helin
> Sent: Sunday, January 7, 2018 11:43 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> > Sent: Friday, December 22, 2017 12:36 PM
> > To: Zhao1, Wei; dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> >
> > Hi Wei:
> >
> > Please check my comment below.
> > Besides, there some line over 80 character warning need to fix
> >
> > Regards
> > Qi
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > > Sent: Friday, November 24, 2017 4:43 PM
> > > To: dev@dpdk.org
> > > Cc: Zhao1, Wei <wei.zhao1@intel.com>
> > > Subject: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API
> > >
> > > Rte_flow actually defined to include RSS, but till now, RSS is out of
> rte_flow.
> > > This patch is to move i40e existing RSS to rte_flow.
> > > This patch also enable queue region configuration using flow API for i40e.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev.c | 91 +++++++++++
> > > drivers/net/i40e/i40e_ethdev.h | 11 ++
> > > drivers/net/i40e/i40e_flow.c | 336
> > > +++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 438 insertions(+)
>
> Have you addressed all the comments? Did I miss anything?
> In addition, I think doc update is needed. e.g. doc/nics/i40e.rst or similar?
>
> Thanks,
> Helin
next prev parent reply other threads:[~2018-01-08 1:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 8:43 Wei Zhao
2017-12-21 3:12 ` Zhang, Helin
2017-12-22 4:36 ` Zhang, Qi Z
2018-01-07 15:43 ` Zhang, Helin
2018-01-08 1:53 ` Zhao1, Wei [this message]
2018-01-08 8:30 ` Zhao1, Wei
2018-01-08 8:33 ` Zhao1, Wei
2018-01-08 8:35 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-01-09 2:33 ` Zhang, Qi Z
2018-01-10 1:53 ` Zhao1, Wei
2018-01-09 9:18 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-01-10 2:10 ` [dpdk-dev] [PATCH v4] " Wei Zhao
2018-01-10 2:58 ` Zhang, Qi Z
2018-01-10 3:36 ` Zhang, Helin
2018-01-10 13:28 ` Ferruh Yigit
2018-01-12 5:50 ` Zhao1, Wei
2018-01-12 6:23 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07C94DC9@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).