From: Matan Azrad <matan@mellanox.com>
To: Noa Ezra <noae@mellanox.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling
Date: Thu, 20 Jun 2019 06:52:19 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019F26B82FF13C8930E6682D2E40@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <AM0PR05MB4388BF46471F9F5C6E5B6E48A0E40@AM0PR05MB4388.eurprd05.prod.outlook.com>
Hi all
> -----Original Message-----
> From: Noa Ezra
> Sent: Thursday, June 20, 2019 8:58 AM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org
> Subject: RE: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling
>
> Hi Maxime,
> Thanks for your comment, please see below.
>
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Wednesday, June 19, 2019 12:10 PM
> > To: Noa Ezra <noae@mellanox.com>
> > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org
> > Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling
> >
> > Hi Noa,
> >
> > On 6/19/19 8:13 AM, Noa Ezra wrote:
> > > Rx mergeable buffers is a virtio feature that allows chaining of
> > > multiple virtio descriptors to handle large packet size.
> > > This behavior is supported and enabled by default, however in case
> > > the user knows that rx mergeable buffers are not needed, he can
> > > disable the feature.
> > > The user should also set mrg_rxbuf=off in virtual machine's xml.
> >
> > I'm not sure to understand why it is needed, as the vhost-user library
> > supports the feature, it's better to let it being advertised.
> >
> > As you say, it is up to the user to disable it in the VM's XML.
> > Done this way, the feature won't be negotiated.
> >
> I agree with you, I'll remove this patch from the series.
Are you sure that no performance impact exists for redundant merg-rx-buf configuration here?
What if the second side want it and the current side no?
It may be that the vhost PMD user may want to disable it to save performance from some reasons, no?
next prev parent reply other threads:[~2019-06-20 6:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 6:13 [dpdk-dev] [PATCH 0/2] support tso and " Noa Ezra
2019-06-19 6:13 ` [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling Noa Ezra
2019-06-19 9:53 ` Maxime Coquelin
2019-06-20 2:26 ` Tiwei Bie
2019-06-20 6:08 ` Matan Azrad
2019-06-20 7:25 ` Maxime Coquelin
2019-08-30 8:44 ` Maxime Coquelin
2019-09-30 9:02 ` Maxime Coquelin
2019-06-19 6:13 ` [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling Noa Ezra
2019-06-19 9:10 ` Maxime Coquelin
2019-06-20 5:57 ` Noa Ezra
2019-06-20 6:52 ` Matan Azrad [this message]
2019-06-20 7:19 ` Maxime Coquelin
2019-06-20 7:55 ` Matan Azrad
2019-06-26 7:50 ` Matan Azrad
2019-06-26 10:27 ` Maxime Coquelin
2019-06-26 11:18 ` Matan Azrad
2019-06-26 12:05 ` Maxime Coquelin
2019-06-26 13:24 ` Matan Azrad
2019-06-26 14:17 ` Maxime Coquelin
2019-06-27 5:04 ` Matan Azrad
2019-08-30 8:48 ` Maxime Coquelin
2019-06-20 7:27 ` Maxime Coquelin
2019-09-30 9:04 ` Maxime Coquelin
2019-06-19 14:20 ` [dpdk-dev] [PATCH 0/2] support tso and " Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019F26B82FF13C8930E6682D2E40@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=noae@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).