From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Dekel Peled <dekelp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount optimization
Date: Wed, 13 Nov 2019 06:23:39 +0000 [thread overview]
Message-ID: <AM4PR05MB326537B1AC9AD5468E739D9CD2760@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1573596010-9467-1-git-send-email-matan@mellanox.com>
> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Wednesday, November 13, 2019 0:00
> To: dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; Dekel Peled
> <dekelp@mellanox.com>
> Subject: [PATCH v2] net/mlx5: revert default rules amount optimization
>
> This reverts commit 304ffe576f239e5405228c0feec04b6138d525b7.
>
> It tried to optimize the amount of the default flow rules and created it only
> once on top of the PF representor.
>
> For each FDB rule, the default port ID to match on is like of the port that
> triggers the flow.
>
> Hence, the single default rule will not be matched on the VF traffic.
>
> As a result, all the traffic of the VFs will not match to the jump flow in the
> root table and will always be forwarded to the representor port.
>
> Revert the commit.
>
> Fixes: 304ffe576f23 ("net/mlx5: fix condition to create default rule")
> Cc: dekelp@mellanox.com
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
next prev parent reply other threads:[~2019-11-13 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 21:47 [dpdk-dev] [PATCH] " Matan Azrad
2019-11-12 22:00 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2019-11-13 6:23 ` Slava Ovsiienko [this message]
2019-11-13 9:37 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB326537B1AC9AD5468E739D9CD2760@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).