DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: David Christensen <drc@linux.vnet.ibm.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Phil Yang <Phil.Yang@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic compare exchange test
Date: Fri, 3 Sep 2021 06:59:21 +0000	[thread overview]
Message-ID: <AM5PR0802MB2465E3F94EFC824C316CF9039ECF9@AM5PR0802MB2465.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210902174104.3181444-1-drc@linux.vnet.ibm.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Christensen
> Sent: Friday, September 3, 2021 1:41 AM
> To: dev@dpdk.org
> Cc: Phil Yang <Phil.Yang@arm.com>; stable@dpdk.org; David Christensen
> <drc@linux.vnet.ibm.com>
> Subject: [dpdk-dev] [PATCH] test/atomic: fix false failures for 128-bit atomic
> compare exchange test
> 
> When checking the results of the rte_atomic128_cmp_exchange() function,
> current code compares the values of a uint32_t and a uint64_t variable.
> If the number of lcores used by the test is large, or the value of the iteration
> count N is increased, the variable size mimatch can cause a false test failure.
> Modify the comparison to compare uint64_t values.
> 
> Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange
> test")
> Cc: phil.yang@arm.com

This mail address is unreachable. 

I reproduced the issue on a 160-core aarch64 machine with increased N.

Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
>  app/test/test_atomic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index
> f10f555af8..ce0c259bd7 100644
> --- a/app/test/test_atomic.c
> +++ b/app/test/test_atomic.c
> @@ -591,7 +591,7 @@ test_atomic(void)
>  	rte_atomic32_clear(&synchro);
> 
>  	iterations = count128.val[0] - count128.val[1];
> -	if (iterations != 4*N*(rte_lcore_count()-1)) {
> +	if (iterations != (uint64_t)4*N*(rte_lcore_count()-1)) {
>  		printf("128-bit compare and swap failed\n");
>  		return -1;
>  	}
> --
> 2.27.0


  reply	other threads:[~2021-09-03  6:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 17:41 David Christensen
2021-09-03  6:59 ` Ruifeng Wang [this message]
2021-09-08 17:25 ` [dpdk-dev] [PATCH v2] " David Christensen
2021-09-08 17:48 ` David Christensen
2021-10-14 15:28   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0802MB2465E3F94EFC824C316CF9039ECF9@AM5PR0802MB2465.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=Phil.Yang@arm.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).