Re: [dpdk-dev] [PATCH v2] eal/arm64: support ASan

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Volodymyr Fialko
> Sent: Tuesday, November 9, 2021 6:46 AM
> To: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: jerinj@marvell.com; Volodymyr Fialko <vfialko@marvell.com>; David
> Marchand <david.marchand@redhat.com>
> Subject: [dpdk-dev] [PATCH v2] eal/arm64: support ASan
> 
> This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan
> documentation. This offset should cover all arm64 VMAs supported by ASan.
> 
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> Changes since v1:
> - changed the subject
> - rewrite checks in "elif" manner
> ---
>  config/meson.build             | 2 +-
>  doc/guides/prog_guide/asan.rst | 2 +-
>  lib/eal/common/malloc_elem.h   | 2 ++
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/config/meson.build b/config/meson.build index
> 17b5bec406..7eb710c08d 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -428,7 +428,7 @@ if get_option('b_sanitize') == 'address' or
> get_option('b_sanitize') == 'address
>          dpdk_extra_ldflags += '-lasan'
>      endif
> 
> -    if is_linux and arch_subdir == 'x86' and dpdk_conf.get('RTE_ARCH_64')
> +    if is_linux and arch_subdir in ['x86', 'arm'] and
> + dpdk_conf.get('RTE_ARCH_64')
>          dpdk_conf.set10('RTE_MALLOC_ASAN', true)
>      endif
>  endif
> diff --git a/doc/guides/prog_guide/asan.rst
> b/doc/guides/prog_guide/asan.rst index 6d1b871c93..28b2382fc7 100644
> --- a/doc/guides/prog_guide/asan.rst
> +++ b/doc/guides/prog_guide/asan.rst
> @@ -33,7 +33,7 @@ Example::
>      "stty echo" command when an error occurs.
> 
>  ASan is aware of DPDK memory allocations, thanks to added instrumentation.
> -This is only enabled on x86_64 at the moment.
> +This is enabled on x86_64 and arm64 at the moment.
>  Other architectures may have to define ASAN_SHADOW_OFFSET.
> 
>  Example heap-buffer-overflow error
> diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
> index 262d69bb3e..26e937cea0 100644
> --- a/lib/eal/common/malloc_elem.h
> +++ b/lib/eal/common/malloc_elem.h
> @@ -106,6 +106,8 @@ malloc_elem_cookies_ok(const struct malloc_elem
> *elem)
> 
>  #ifdef RTE_ARCH_X86_64
>  #define ASAN_SHADOW_OFFSET    0x00007fff8000
> +#elif defined(RTE_ARCH_ARM64)
> +#define ASAN_SHADOW_OFFSET    0x001000000000
As Jerin mentioned, it is better to add a comment on why this value was selected.
My search told me that "this value has to match kAArch64_ShadowOffset64 as defined
in libsanitizer/asan/asan_mapping.h".

With the change,
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

>  #endif
> 
>  #define ASAN_SHADOW_GRAIN_SIZE	8
> --
> 2.25.1