From: Tal Shnaiderman <talshn@nvidia.com>
To: Ranjit Menon <ranjit.menon@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Ophir Munk <ophirmu@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang
Date: Fri, 2 Oct 2020 23:22:12 +0000 [thread overview]
Message-ID: <BY5PR12MB43231529648CEF4F93380F92A4310@BY5PR12MB4323.namprd12.prod.outlook.com> (raw)
In-Reply-To: <b55141e7-ecd7-3bd0-1f62-77558a3eab52@intel.com>
> From: Ranjit Menon <ranjit.menon@intel.com>
> Subject: Re: [PATCH] eal/windows: export all built functions for clang
>
> Hi Tal,
>
> On 10/2/2020 12:18 PM, Tal Shnaiderman wrote:
> > export for clang build all the functions currently built on Windows
> > and listed in rte_eal_version.map by adding them to
> > rte_eal_exports.def.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
>
> While you are at this, can we sort and re-order the functions alphabetically?
>
> For instance, I can see some rte_fbarray*, rte_mem*, per_lcore* functions
> in multiple locations.
>
> Also as an aside, Bruce (in cc:) had suggested in a private thread that we
> should start looking into auto-generating this .def file now that it has most of
> the functions defined in the .map file.
>
> ranjit m.
Hi Ranjit,
I tried to keep the file structure similar to the original rte_eal_version.map file, in the map file each DPDK release exported additional functions so the whole file isn't sorted but each release section is.
I not sure however if you can add the comments separating the sections to the def file.
Regarding autogenerating this file, there is actually an open task on it, MSFT team are on it and DmitryK even suggested a way to generate it using DUMPBIN, however until this is done we should have all the exported functions updated in the def file.
next prev parent reply other threads:[~2020-10-02 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 19:18 Tal Shnaiderman
2020-10-02 21:07 ` Ranjit Menon
2020-10-02 23:22 ` Tal Shnaiderman [this message]
2020-10-06 8:00 ` Tal Shnaiderman
2020-10-06 18:57 ` Ranjit Menon
2020-10-06 20:47 ` Dmitry Kozlyuk
2020-10-07 7:19 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2020-10-07 11:32 ` John Alexander
2020-10-07 14:14 ` Tal Shnaiderman
2020-10-14 9:35 ` Dmitry Kozlyuk
2020-10-14 9:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB43231529648CEF4F93380F92A4310@BY5PR12MB4323.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=ophirmu@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).