Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

[Tal Shnaiderman <talshn@nvidia.com>]

> Subject: Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for
> clang
> 
> External email: Use caution opening links or attachments
> 
> 
> > From: Ranjit Menon <ranjit.menon@intel.com>
> > Subject: Re: [PATCH] eal/windows: export all built functions for clang
> >
> > Hi Tal,
> >
> > On 10/2/2020 12:18 PM, Tal Shnaiderman wrote:
> > > export for clang build all the functions currently built on Windows
> > > and listed in rte_eal_version.map by adding them to
> > > rte_eal_exports.def.
> > >
> > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > > ---
> >
> > While you are at this, can we sort and re-order the functions alphabetically?
> >
> > For instance, I can see some rte_fbarray*, rte_mem*, per_lcore*
> > functions in multiple locations.
> >
> > Also as an aside, Bruce (in cc:) had suggested in a private thread
> > that we should start looking into auto-generating this .def file now
> > that it has most of the functions defined in the .map file.
> >
> > ranjit m.
> 
> Hi Ranjit,
> 
> I tried to keep the file structure similar to the original rte_eal_version.map
> file, in the map file each DPDK release exported additional functions so the
> whole file isn't sorted but each release section is.
> 
> I not sure however if you can add the comments separating the sections to
> the def file.
> 
> Regarding autogenerating this file, there is actually an open task on it, MSFT
> team are on it and DmitryK even suggested a way to generate it using
> DUMPBIN, however until this is done we should have all the exported
> functions updated in the def file.

Hi Ranjit,

Any other concerns regarding this patch? 

If not can you Ack it?

Thanks,

Tal.