DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API
@ 2020-07-30 17:13 Akhil Goyal
  2020-07-30 17:17 ` Hemant Agrawal
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Akhil Goyal @ 2020-07-30 17:13 UTC (permalink / raw)
  To: dev, anoobj, radu.nicolau, konstantin.ananyev, declan.doherty,
	roy.fan.zhang
  Cc: thomas, fiona.trahe, adwivedi, hemant.agrawal, Akhil Goyal

The API ``rte_security_session_create`` takes only single mempool
for session and session private data. So the application need to create
mempool for twice the number of sessions needed and will also lead to
wastage of memory as session private data need more memory compared to session.
Hence the API will be modified to take two mempool pointers - one for session
and one for private data. This is very similar to crypto based session
create APIs.

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a4..9ed7b55e6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -126,6 +126,13 @@ Deprecation Notices
   to one it means it represents IV, when is set to zero it means J0 is used
   directly, in this case 16 bytes of J0 need to be passed.
 
+* security: The API ``rte_security_session_create`` takes only single mempool
+  for session and session private data. So the application need to create
+  mempool for twice the number of sessions needed and will also lead to
+  wastage of memory as session private data need more memory compared to session.
+  Hence the API will be modified to take two mempool pointers - one for session
+  and one for private data.
+
 * sched: To allow more traffic classes, flexible mapping of pipe queues to
   traffic classes, and subport level configuration of pipes and queues
   changes will be made to macros, data structures and API functions defined
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API
  2020-07-30 17:13 [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API Akhil Goyal
@ 2020-07-30 17:17 ` Hemant Agrawal
  2020-07-30 17:26 ` [dpdk-dev] [EXT] " Anoob Joseph
  2020-07-31  9:58 ` [dpdk-dev] " Ananyev, Konstantin
  2 siblings, 0 replies; 6+ messages in thread
From: Hemant Agrawal @ 2020-07-30 17:17 UTC (permalink / raw)
  To: Akhil Goyal, dev, anoobj, radu.nicolau, konstantin.ananyev,
	declan.doherty, roy.fan.zhang
  Cc: thomas, fiona.trahe, adwivedi, Akhil Goyal

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH] doc: add deprecation notice for security session create API
  2020-07-30 17:13 [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API Akhil Goyal
  2020-07-30 17:17 ` Hemant Agrawal
@ 2020-07-30 17:26 ` " Anoob Joseph
  2020-07-31  9:58 ` [dpdk-dev] " Ananyev, Konstantin
  2 siblings, 0 replies; 6+ messages in thread
From: Anoob Joseph @ 2020-07-30 17:26 UTC (permalink / raw)
  To: Akhil Goyal, dev, radu.nicolau, konstantin.ananyev,
	declan.doherty, roy.fan.zhang
  Cc: thomas, fiona.trahe, Ankur Dwivedi, hemant.agrawal


> The API ``rte_security_session_create`` takes only single mempool for session
> and session private data. So the application need to create mempool for twice
> the number of sessions needed and will also lead to wastage of memory as
> session private data need more memory compared to session.
> Hence the API will be modified to take two mempool pointers - one for session
> and one for private data. This is very similar to crypto based session create APIs.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API
  2020-07-30 17:13 [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API Akhil Goyal
  2020-07-30 17:17 ` Hemant Agrawal
  2020-07-30 17:26 ` [dpdk-dev] [EXT] " Anoob Joseph
@ 2020-07-31  9:58 ` " Ananyev, Konstantin
  2020-08-06 16:19   ` Thomas Monjalon
  2 siblings, 1 reply; 6+ messages in thread
From: Ananyev, Konstantin @ 2020-07-31  9:58 UTC (permalink / raw)
  To: Akhil Goyal, dev, anoobj, Nicolau, Radu, Doherty, Declan, Zhang, Roy Fan
  Cc: thomas, Trahe, Fiona, adwivedi, hemant.agrawal



> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Thursday, July 30, 2020 8:14 PM
> To: dev@dpdk.org; anoobj@marvell.com; Nicolau, Radu <radu.nicolau@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Doherty, Declan <declan.doherty@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: thomas@monjalon.net; Trahe, Fiona <fiona.trahe@intel.com>; adwivedi@marvell.com; hemant.agrawal@nxp.com; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: [PATCH] doc: add deprecation notice for security session create API
> 
> The API ``rte_security_session_create`` takes only single mempool
> for session and session private data. So the application need to create
> mempool for twice the number of sessions needed and will also lead to
> wastage of memory as session private data need more memory compared to session.
> Hence the API will be modified to take two mempool pointers - one for session
> and one for private data. This is very similar to crypto based session
> create APIs.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a4..9ed7b55e6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -126,6 +126,13 @@ Deprecation Notices
>    to one it means it represents IV, when is set to zero it means J0 is used
>    directly, in this case 16 bytes of J0 need to be passed.
> 
> +* security: The API ``rte_security_session_create`` takes only single mempool
> +  for session and session private data. So the application need to create
> +  mempool for twice the number of sessions needed and will also lead to
> +  wastage of memory as session private data need more memory compared to session.
> +  Hence the API will be modified to take two mempool pointers - one for session
> +  and one for private data.
> +
>  * sched: To allow more traffic classes, flexible mapping of pipe queues to
>    traffic classes, and subport level configuration of pipes and queues
>    changes will be made to macros, data structures and API functions defined
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API
  2020-07-31  9:58 ` [dpdk-dev] " Ananyev, Konstantin
@ 2020-08-06 16:19   ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-06 16:19 UTC (permalink / raw)
  To: Akhil Goyal
  Cc: dev, anoobj, Nicolau, Radu, Doherty, Declan, Zhang, Roy Fan,
	Trahe, Fiona, adwivedi, hemant.agrawal, Ananyev, Konstantin

> > The API ``rte_security_session_create`` takes only single mempool
> > for session and session private data. So the application need to create
> > mempool for twice the number of sessions needed and will also lead to
> > wastage of memory as session private data need more memory compared to session.
> > Hence the API will be modified to take two mempool pointers - one for session
> > and one for private data. This is very similar to crypto based session
> > create APIs.
> > 
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> > +* security: The API ``rte_security_session_create`` takes only single mempool
> > +  for session and session private data. So the application need to create
> > +  mempool for twice the number of sessions needed and will also lead to
> > +  wastage of memory as session private data need more memory compared to session.
> > +  Hence the API will be modified to take two mempool pointers - one for session
> > +  and one for private data.
> > +
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API
@ 2020-07-31  9:29 Coyle, David
  0 siblings, 0 replies; 6+ messages in thread
From: Coyle, David @ 2020-07-31  9:29 UTC (permalink / raw)
  To: Akhil Goyal, dev, anoobj, Nicolau, Radu, Ananyev, Konstantin,
	Doherty, Declan, Zhang, Roy Fan
  Cc: thomas, Trahe, Fiona, adwivedi, hemant.agrawal

> The API ``rte_security_session_create`` takes only single mempool for
> session and session private data. So the application need to create mempool
> for twice the number of sessions needed and will also lead to wastage of
> memory as session private data need more memory compared to session.
> Hence the API will be modified to take two mempool pointers - one for
> session and one for private data. This is very similar to crypto based session
> create APIs.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
Acked-by: David Coyle <david.coyle@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 17:13 [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API Akhil Goyal
2020-07-30 17:17 ` Hemant Agrawal
2020-07-30 17:26 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-07-31  9:58 ` [dpdk-dev] " Ananyev, Konstantin
2020-08-06 16:19   ` Thomas Monjalon
2020-07-31  9:29 Coyle, David

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox