From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Gagandeep Singh <g.singh@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] kni: update kernel API to receive packets
Date: Wed, 20 Apr 2022 07:45:05 +0000 [thread overview]
Message-ID: <BYAPR11MB34950B6BC7535D889B0D5396F7F59@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220420050309.1055593-1-g.singh@nxp.com>
> -----Original Message-----
> From: Gagandeep Singh <g.singh@nxp.com>
> Sent: Wednesday, April 20, 2022 13:03
> To: dev@dpdk.org
> Cc: Gagandeep Singh <g.singh@nxp.com>
> Subject: [PATCH] kni: update kernel API to receive packets
>
> API 'netif_rx_ni()' has been removed in kernel with commit:
> baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
>
It should be 5.18:
git describe --contains baebdf48c3600
v5.18-rc1~136^2~356^2~1
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/core/dev.c?h=v5.18-rc1#n4917
vs
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/net/core/dev.c?h=v5.17.3#n4836
> The API netif_rx() can be used for any context to receive packets
> from device drivers.
>
> This patch replaces the API netif_rx_ni() with netif_rx() for
> kernel version 5.17 and above.
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
> kernel/linux/kni/kni_net.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 29e5b9e21f..764ac0b225 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -441,7 +441,11 @@ kni_net_rx_normal(struct kni_dev *kni)
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> /* Call netif interface */
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 17, 0)
> + netif_rx(skb);
> +#else
> netif_rx_ni(skb);
> +#endif
>
> /* Update statistics */
> dev->stats.rx_bytes += len;
> --
> 2.25.1
next prev parent reply other threads:[~2022-04-20 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 12:23 Gagandeep Singh
2022-04-15 3:24 ` Harold Huang
2022-04-15 4:07 ` Gagandeep Singh
2022-04-15 12:30 ` Ferruh Yigit
2022-04-15 14:59 ` Stephen Hemminger
2022-04-18 11:33 ` Gagandeep Singh
2022-04-20 5:03 ` Gagandeep Singh
2022-04-20 7:45 ` Wang, Haiyue [this message]
2022-04-20 10:39 ` Gagandeep Singh
2022-04-21 3:45 ` [PATCH v2] " Gagandeep Singh
2022-04-21 8:29 ` Ferruh Yigit
2022-04-21 8:59 ` [PATCH v3] " Gagandeep Singh
2022-05-23 9:15 ` Min Hu (Connor)
2022-06-26 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB34950B6BC7535D889B0D5396F7F59@BYAPR11MB3495.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).