From: Gagandeep Singh <G.Singh@nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: Harold Huang <baymaxhuang@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] kni: update kernel API to receive packets
Date: Mon, 18 Apr 2022 11:33:01 +0000 [thread overview]
Message-ID: <AS8PR04MB8198A3AD1035DBE4BC9169D7E1F39@AS8PR04MB8198.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220415075959.27778efd@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, April 15, 2022 8:30 PM
> To: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Cc: Gagandeep Singh <G.Singh@nxp.com>; Harold Huang
> <baymaxhuang@gmail.com>; dev@dpdk.org
> Subject: Re: [PATCH] kni: update kernel API to receive packets
>
> On Fri, 15 Apr 2022 13:30:33 +0100
> Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
>
> > >> But this change would cause KNI kernel module does not work in the
> > >> old kernel without this patch. I suggested using netif_rx_ni to keep
> compatibility.
> > >
> > > netif_rx() API exists from very older versions of kernel before
> > > v2.6. There will be no compilation issues. Only difference was,
> > > netif_rx_ni() can be used in noninterrupt contexts to improve performance.
> >
> > May not be compilation issue, but with old kernels won't the behavior
> > be different when 'netif_rx_ni()' switched to 'netif_rx()
>
> Probably best handled by #ifdef on kernel version but will be a mess for
> backports to distro kernels.
>
> Looks like:
>
> Older -> New
> netif_rx_ni netif_rx
> neitf_rx __netif_rx
If it is ok for everyone, I can add #ifdef for kernel version >= 5.17 to use API netif_rx, to
avoid any functional/performance impact with old kernels.
next prev parent reply other threads:[~2022-04-18 11:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 12:23 Gagandeep Singh
2022-04-15 3:24 ` Harold Huang
2022-04-15 4:07 ` Gagandeep Singh
2022-04-15 12:30 ` Ferruh Yigit
2022-04-15 14:59 ` Stephen Hemminger
2022-04-18 11:33 ` Gagandeep Singh [this message]
2022-04-20 5:03 ` Gagandeep Singh
2022-04-20 7:45 ` Wang, Haiyue
2022-04-20 10:39 ` Gagandeep Singh
2022-04-21 3:45 ` [PATCH v2] " Gagandeep Singh
2022-04-21 8:29 ` Ferruh Yigit
2022-04-21 8:59 ` [PATCH v3] " Gagandeep Singh
2022-05-23 9:15 ` Min Hu (Connor)
2022-06-26 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB8198A3AD1035DBE4BC9169D7E1F39@AS8PR04MB8198.eurprd04.prod.outlook.com \
--to=g.singh@nxp.com \
--cc=baymaxhuang@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).