From: "Walsh, Conor" <conor.walsh@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag
Date: Mon, 14 Sep 2020 13:51:04 +0000 [thread overview]
Message-ID: <BYAPR11MB379905BEECFC670DCAF3988EFF230@BYAPR11MB3799.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zn2BOE_RECDd9B_WT9NTv=B82-BAmvzpUxJt5-Z=mbQA@mail.gmail.com>
Hi David,
> Hello Conor,
>
> On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh <conor.walsh@intel.com>
> wrote:
> >
> > Since librte_ipsec was first introduced in 19.02 and there were no
> > changes in it's public API since 19.11, it should be considered mature
> > enough to remove the 'experimental' tag from it.
> > The RTE_SATP_LOG2_NUM enum is also being dropped from
> rte_ipsec_sa.h
> > to avoid possible ABI problems in the future.
> >
> > ---
> > v2: RTE_SATP_LOG2_NUM dropped from enum
>
> Small comments that I guess could be fixed while applying.
>
> Commit title prefixes don't start with lib/.
>
[...]
> There is no ABI compat in this release, and this is an API change.
>
> Documentation blocks are separated with double empty lines (like it was
> before your patch).
>
I will correct these issues, V3 coming soon.
/Conor.
next prev parent reply other threads:[~2020-09-14 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:48 [dpdk-dev] [PATCH] " Conor Walsh
2020-09-08 11:36 ` Ananyev, Konstantin
2020-09-14 12:53 ` [dpdk-dev] [PATCH v2] " Conor Walsh
2020-09-14 13:25 ` David Marchand
2020-09-14 13:51 ` Walsh, Conor [this message]
2020-09-14 14:10 ` [dpdk-dev] [PATCH v3] ipsec: " Conor Walsh
2020-09-16 11:22 ` Ananyev, Konstantin
2020-10-05 8:59 ` Kinsella, Ray
2020-10-06 20:11 ` Akhil Goyal
2020-10-06 20:29 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB379905BEECFC670DCAF3988EFF230@BYAPR11MB3799.namprd11.prod.outlook.com \
--to=conor.walsh@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).