Re: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE

["Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Tuesday, November 5, 2019 10:07 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE
> 
> The ptype bitmap calculation for GRE packet is modified by misktake due to

Minor nit (if not already fixed in subsequent patch): misktake => mistake

> commit fc845a9d78ce
> ("net/ice/base: fix ptype mapping pollution from GTP flow") which is target for
> GTP packet. The patch rollback that part of code.
> 
> Fixes: fc845a9d78ce ("net/ice/base: fix ptype mapping pollution from GTP flow")
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> v3:
> - fix commit log format.
> v2:
> - fix coding style issue
> 
>  drivers/net/ice/base/ice_flow.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
> index d6e0556e7..eaa7a3b96 100644
> --- a/drivers/net/ice/base/ice_flow.c
> +++ b/drivers/net/ice/base/ice_flow.c
> @@ -573,9 +573,11 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
>  			ice_and_bitmap(params->ptypes, params->ptypes, src,
>  				       ICE_FLOW_PTYPE_MAX);
>  		} else if (hdrs & ICE_FLOW_SEG_HDR_GRE) {
> -			src = (const ice_bitmap_t *)ice_ptypes_gre_of;
> -			ice_and_bitmap(params->ptypes, params->ptypes,
> -				       src, ICE_FLOW_PTYPE_MAX);
> +			if (!i) {
> +				src = (const ice_bitmap_t *)ice_ptypes_gre_of;
> +				ice_and_bitmap(params->ptypes, params-
> >ptypes,
> +					       src, ICE_FLOW_PTYPE_MAX);
> +			}
>  		} else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) {
>  			src = (const ice_bitmap_t *)ice_ptypes_gtpc;
>  			ice_and_bitmap(params->ptypes, params->ptypes,
> --
> 2.13.6