DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jan Remeš" <remes@netcope.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rastislav Cernay <cernay@netcope.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/net/nfb: add timestamp support
Date: Fri, 28 Jun 2019 16:12:00 +0200	[thread overview]
Message-ID: <CAAnEdtBJKqunD8QyN_9izovj_A+A9sK0qVPpwpXxdjapJWRMAw@mail.gmail.com> (raw)
In-Reply-To: <2de7358f-189e-e687-4868-0f1c6bd72cb1@intel.com>

On Thu, Jun 27, 2019 at 5:45 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 6/13/2019 1:05 PM, Rastislav Cernay wrote:
> > +Timestamping needs to be enabled during compile time, as there is no way
> > +to check whether a timestamping unit is runnig during run time.
>
> Even if this can't be detected on runtime, it should be possible to configure in
> runtime with device args so need to compile the PMD again to change the behavior.
>
> In this patch default behavior is no timestamps support, same can be done with
> devargs, without any devargs timestamp support disable, but if user provides a
> devarg, like "timestamp=1", feature enabled.
>
> What do you think, can it be possible to convert runtime configuration?

This sounds good. We did not explore the devargs option. We will look
into it, and probably rework this patch and send v2.

Thanks,
  Jan

  reply	other threads:[~2019-06-28 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 12:05 Rastislav Cernay
2019-06-27 15:45 ` Ferruh Yigit
2019-06-28 14:12   ` Jan Remeš [this message]
2019-07-02 10:32 ` [dpdk-dev] [PATCH v2] " Rastislav Cernay
2019-07-03 11:55   ` Ferruh Yigit
2019-07-15 12:03 ` [dpdk-dev] [PATCH v3] " Rastislav Cernay
2019-07-15 13:08   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAnEdtBJKqunD8QyN_9izovj_A+A9sK0qVPpwpXxdjapJWRMAw@mail.gmail.com \
    --to=remes@netcope.com \
    --cc=cernay@netcope.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).