DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Luca Boccassi <bluca@debian.org>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH v2] test/bpf_convert: do not require DNS lookup
Date: Mon, 15 Nov 2021 09:11:03 +0530
Message-ID: <CAH-L+nOyGMSky_C+yJ14CeSgDy7+uraE+cei=JTc5uc1xTdozA@mail.gmail.com> (raw)
In-Reply-To: <20211110161848.34050-1-stephen@networkplumber.org>

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Wed, Nov 10, 2021 at 9:48 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> These tests were using strings with hostname (dpdk.org) and this makes
> test code do a DNS lookup. In container environment used for OpenSuse
> build, DNS is unavailable.  Replace dpdk.org with an IPv4 address
>
extra space character before Replace?

> reserved for documentation (RFC 5737) and use IPv6 in one example (RFC
> 3849).
> Actual addresses don't matter for this test whichis validating tke
>
Missing space between which and is and typo in "the"

> classic BPF to eBPF for common cases.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - use RFC reserved address
>
>  app/test/test_bpf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
> index ef861d05e755..785f3e689e10 100644
> --- a/app/test/test_bpf.c
> +++ b/app/test/test_bpf.c
> @@ -3359,8 +3359,8 @@ static const char * const sample_filters[] = {
>         "dst net 192.168.0.0/24",
>         "dst net 192.168.0.0 mask 255.255.255.0",
>         "port 53",
> -       "host dpdk.org and not (port 80 or port 25)",
> -       "host dpdk.org and not port 80 and not port 25",
> +       "host 192.0.2.1 and not (port 80 or port 25)",
> +       "host 2001:4b98:db0::8 and not port 80 and not port 25",
>         "port not 53 and not arp",
>         "(tcp[0:2] > 1500 and tcp[0:2] < 1550) or (tcp[2:2] > 1500 and
> tcp[2:2] < 1550)",
>         "ether proto 0x888e",
> --
> 2.30.2
>
>

-- 
Regards,
Kalesh A P

[-- Attachment #2: Type: text/html, Size: 2919 bytes --]

  parent reply	other threads:[~2021-11-15  3:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 21:04 [dpdk-dev] [PATCH] " Stephen Hemminger
2021-11-09 22:50 ` Luca Boccassi
2021-11-10 15:22 ` Thomas Monjalon
2021-11-10 16:18 ` [PATCH v2] " Stephen Hemminger
2021-11-14 23:39   ` Luca Boccassi
2021-11-24 18:51     ` Luca Boccassi
2021-11-15  3:41   ` Kalesh Anakkur Purayil [this message]
2021-11-15 23:23   ` [PATCH v3] " Stephen Hemminger
2021-11-15 23:29     ` [PATCH v4] " Stephen Hemminger
2021-11-15 23:29     ` [PATCH v5] " Stephen Hemminger
2021-11-16 13:31       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH-L+nOyGMSky_C+yJ14CeSgDy7+uraE+cei=JTc5uc1xTdozA@mail.gmail.com' \
    --to=kalesh-anakkur.purayil@broadcom.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git