Re: [PATCH v2] test/bpf_convert: do not require DNS lookup

[Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Wed, Nov 10, 2021 at 9:48 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> These tests were using strings with hostname (dpdk.org) and this makes
> test code do a DNS lookup. In container environment used for OpenSuse
> build, DNS is unavailable.  Replace dpdk.org with an IPv4 address
>
extra space character before Replace?

> reserved for documentation (RFC 5737) and use IPv6 in one example (RFC
> 3849).
> Actual addresses don't matter for this test whichis validating tke
>
Missing space between which and is and typo in "the"

> classic BPF to eBPF for common cases.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - use RFC reserved address
>
>  app/test/test_bpf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
> index ef861d05e755..785f3e689e10 100644
> --- a/app/test/test_bpf.c
> +++ b/app/test/test_bpf.c
> @@ -3359,8 +3359,8 @@ static const char * const sample_filters[] = {
>         "dst net 192.168.0.0/24",
>         "dst net 192.168.0.0 mask 255.255.255.0",
>         "port 53",
> -       "host dpdk.org and not (port 80 or port 25)",
> -       "host dpdk.org and not port 80 and not port 25",
> +       "host 192.0.2.1 and not (port 80 or port 25)",
> +       "host 2001:4b98:db0::8 and not port 80 and not port 25",
>         "port not 53 and not arp",
>         "(tcp[0:2] > 1500 and tcp[0:2] < 1550) or (tcp[2:2] > 1500 and
> tcp[2:2] < 1550)",
>         "ether proto 0x888e",
> --
> 2.30.2
>
>

-- 
Regards,
Kalesh A P

[-- Attachment #2: Type: text/html, Size: 2919 bytes --]