Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy

[Rami Rosen <ramirose@gmail.com>]

Checked on Fedora 28

Reviewed-by: Rami Rosen <ramirose at gmail.com>

On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:

> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  app/test-compress-perf/comp_perf_options_parse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-compress-perf/comp_perf_options_parse.c
> b/app/test-compress-perf/comp_perf_options_parse.c
> index 66eb81fc59..d2b208de35 100644
> --- a/app/test-compress-perf/comp_perf_options_parse.c
> +++ b/app/test-compress-perf/comp_perf_options_parse.c
> @@ -373,7 +373,7 @@ parse_driver_name(struct comp_test_data *test_data,
> const char *arg)
>         if (strlen(arg) > (sizeof(test_data->driver_name) - 1))
>                 return -1;
>
> -       rte_strlcpy(test_data->driver_name, arg,
> +       strlcpy(test_data->driver_name, arg,
>                         sizeof(test_data->driver_name));
>
>         return 0;
> @@ -385,7 +385,7 @@ parse_test_file(struct comp_test_data *test_data,
> const char *arg)
>         if (strlen(arg) > (sizeof(test_data->input_file) - 1))
>                 return -1;
>
> -       rte_strlcpy(test_data->input_file, arg,
> sizeof(test_data->input_file));
> +       strlcpy(test_data->input_file, arg, sizeof(test_data->input_file));
>
>         return 0;
>  }
> --
> 2.20.1
>
>

-- 
regards,
Rami Rosen