DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Zoltan Kiss <zoltan.kiss@schaman.hu>, dev <dev@dpdk.org>,
	 Ray Kinsella <mdr@ashroe.eu>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure
Date: Wed, 13 Oct 2021 13:07:51 +0200
Message-ID: <CAJFAV8w2LfguQQnZWTe4yQ0nLdq4y2=N-oECU_5zzU8i=_VHig@mail.gmail.com> (raw)
In-Reply-To: <20211013085723.1206789-1-andrew.rybchenko@oktetlabs.ru>

On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Use correct define as a name array size.
>
> The change breaks ABI and therefore cannot be backported to
> stable branches.
>
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Reviewed-by: David Marchand <david.marchand@redhat.com>

Good catch, I guess we can clean ring too, quick grep:

lib/ring/rte_ring_core.h-struct rte_ring {
lib/ring/rte_ring_core.h-       /*
lib/ring/rte_ring_core.h:        * Note: this field kept the
RTE_MEMZONE_NAMESIZE size due to ABI
lib/ring/rte_ring_core.h-        * compatibility requirements, it
could be changed to RTE_RING_NAMESIZE
lib/ring/rte_ring_core.h:        * next time the ABI changes
lib/ring/rte_ring_core.h-        */
lib/ring/rte_ring_core.h-       char name[RTE_MEMZONE_NAMESIZE]
__rte_cache_aligned;


-- 
David Marchand


  reply	other threads:[~2021-10-13 11:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  8:57 Andrew Rybchenko
2021-10-13 11:07 ` David Marchand [this message]
2021-10-13 11:14   ` Andrew Rybchenko
2021-10-13 17:30     ` Honnappa Nagarahalli
2021-10-13 20:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8w2LfguQQnZWTe4yQ0nLdq4y2=N-oECU_5zzU8i=_VHig@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    --cc=zoltan.kiss@schaman.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git