From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/freebsd: fix missing write to internal config
Date: Wed, 26 Jun 2019 14:03:47 +0200 [thread overview]
Message-ID: <CAJFAV8wUdaqBBOZd3-EOXdiFVgDUcVos29vSBmegvmsmWuUjSw@mail.gmail.com> (raw)
In-Reply-To: <f4c041a147e3b6b29d70e056653fd3c163e1d4ce.1561477829.git.anatoly.burakov@intel.com>
On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov <anatoly.burakov@intel.com>
wrote:
> When init is complete, EAL is supposed to update internal config
> to indicate that initialization is complete. Add missing write.
>
> Fixes: a99c96e96ad3 ("eal: add internal flag of init completed")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> lib/librte_eal/freebsd/eal/eal.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index 4eaa53195..8c399c799 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -566,6 +566,8 @@ rte_eal_mcfg_complete(void)
> /* ALL shared mem_config related INIT DONE */
> if (rte_config.process_type == RTE_PROC_PRIMARY)
> rte_config.mem_config->magic = RTE_MAGIC;
> +
> + internal_config.init_complete = 1;
> }
>
> /* return non-zero if hugepages are enabled. */
> --
> 2.17.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-06-26 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 15:50 [dpdk-dev] " Anatoly Burakov
2019-06-25 15:50 ` [dpdk-dev] [PATCH 2/2] eal/freebsd: add config reattach Anatoly Burakov
2019-06-26 12:03 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-26 12:21 ` David Marchand
2019-06-26 12:50 ` Burakov, Anatoly
2019-06-26 12:49 ` Burakov, Anatoly
2019-06-26 12:03 ` David Marchand [this message]
2019-06-27 11:33 ` [dpdk-dev] [PATCH v2 1/2] eal/freebsd: fix missing write to internal config Anatoly Burakov
2019-06-27 11:33 ` [dpdk-dev] [PATCH v2 2/2] eal/freebsd: add config reattach Anatoly Burakov
2019-06-27 11:46 ` David Marchand
2019-07-01 16:02 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wUdaqBBOZd3-EOXdiFVgDUcVos29vSBmegvmsmWuUjSw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).