From: David Marchand <david.marchand@redhat.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h
Date: Thu, 7 Jan 2021 09:01:49 +0100 [thread overview]
Message-ID: <CAJFAV8wZWV-tNqT1GKB9BfO4B4mc0wVZGQzoXKctQpMY3bEivA@mail.gmail.com> (raw)
In-Reply-To: <CAN44U22GO=Km7iZUX1jCF8hzX8T6xWwc3a5K_GUY0oEVeF2MOA@mail.gmail.com>
On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan
<ashish.sadanandan@gmail.com> wrote:
>
> Hi Olivier,
>
> On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz <olivier.matz@6wind.com> wrote:
> >
> > Hi Ashish,
> >
> > Yes, it should reference the patch that introduced the issue. In this case,
> > it should be:
> >
> > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> >
> > Can you please also change the title to start with "fix", for
> > instance like this:
> >
> > mbuf: fix inclusion from c++
> >
> > You can also add "Cc: stable@dpdk.org" in the commit log.
> >
> > Some documentation can be found in doc/guides/contributing/patches.rst
>
> Thanks for the pointers. I've made the changes above. However I don't
> know if I'm using the message ID for --in-reply-to correctly, since I
> seem to be creating a new thread each time.
You can get the message ID in various places.
I usually take the info from patchwork and update the previous patch
state to Superseded at the same time.
So in your case, the v1 patch was:
http://patchwork.dpdk.org/patch/85878/
Message ID: 20201229194144.17824-1-ashish.sadanandan@gmail.com
So for the v2:
git send-email --to dev@dpdk.org --cc-cmd ./devtools/get-maintainer.sh
--cc XXX --in-reply-to
'20201229194144.17824-1-ashish.sadanandan@gmail.com' v2-*.patch
--
David Marchand
next prev parent reply other threads:[~2021-01-07 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 19:41 Ashish Sadanandan
2020-12-29 20:10 ` Stephen Hemminger
2020-12-29 20:22 ` Ashish Sadanandan
2021-01-06 13:21 ` Olivier Matz
2021-01-07 1:42 ` Ashish Sadanandan
2021-01-07 8:01 ` David Marchand [this message]
2021-01-07 17:20 ` Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wZWV-tNqT1GKB9BfO4B4mc0wVZGQzoXKctQpMY3bEivA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ashish.sadanandan@gmail.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).