DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples: fix linking against specific drivers
@ 2020-10-27 17:19 Bruce Richardson
  2020-10-30 13:35 ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-10-27 17:19 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

Some example apps rely on driver-specific functionality and link explicitly
against those drivers. These apps need their makefiles updated to take
account of the renaming of the driver libs.

Fixes: a20b2c01a7a1 ("build: standardize component names and defines")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/bond/Makefile             | 2 +-
 examples/ethtool/lib/Makefile      | 2 +-
 examples/vm_power_manager/Makefile | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/bond/Makefile b/examples/bond/Makefile
index 4e560f574c..8700b589fb 100644
--- a/examples/bond/Makefile
+++ b/examples/bond/Makefile
@@ -19,7 +19,7 @@ shared: build/$(APP)-shared
 static: build/$(APP)-static
 	ln -sf $(APP)-static build/$(APP)
 
-LDFLAGS += -lrte_pmd_bond
+LDFLAGS += -lrte_net_bond
 
 PKGCONF ?= pkg-config
 
diff --git a/examples/ethtool/lib/Makefile b/examples/ethtool/lib/Makefile
index 3bc2b9d8ba..b4af9b0c91 100644
--- a/examples/ethtool/lib/Makefile
+++ b/examples/ethtool/lib/Makefile
@@ -27,7 +27,7 @@ LDFLAGS += -Wl,--no-undefined $(LDFLAGS_SHARED)
 
 # check for ixgbe by grepping pre-processor output
 ifneq ($(shell $(CC) $(CFLAGS) -dM -E - < /dev/null | grep IXGBE),)
-LDFLAGS += -lrte_pmd_ixgbe
+LDFLAGS += -lrte_net_ixgbe
 endif
 
 .PHONY: all clean static shared
diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile
index 87b9744d8c..027d17c7ef 100644
--- a/examples/vm_power_manager/Makefile
+++ b/examples/vm_power_manager/Makefile
@@ -44,7 +44,7 @@ CFLAGS += -DUSE_JANSSON
 endif
 
 # for shared library builds, we need to explicitly link these PMDs
-LDFLAGS_SHARED += -lrte_pmd_ixgbe -lrte_pmd_i40e -lrte_pmd_bnxt
+LDFLAGS_SHARED += -lrte_net_ixgbe -lrte_net_i40e -lrte_net_bnxt
 
 build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
 	$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples: fix linking against specific drivers
  2020-10-27 17:19 [dpdk-dev] [PATCH] examples: fix linking against specific drivers Bruce Richardson
@ 2020-10-30 13:35 ` David Marchand
  2020-11-02 17:47   ` Richardson, Bruce
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-10-30 13:35 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, Thomas Monjalon

On Tue, Oct 27, 2020 at 6:20 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some example apps rely on driver-specific functionality and link explicitly
> against those drivers. These apps need their makefiles updated to take
> account of the renaming of the driver libs.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks Bruce.


I think the documentation would also need some fixes as I can see a
lot of references to librte_pmd_.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples: fix linking against specific drivers
  2020-10-30 13:35 ` David Marchand
@ 2020-11-02 17:47   ` Richardson, Bruce
  0 siblings, 0 replies; 3+ messages in thread
From: Richardson, Bruce @ 2020-11-02 17:47 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Thomas Monjalon



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 30, 2020 1:36 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH] examples: fix linking against specific
> drivers
> 
> On Tue, Oct 27, 2020 at 6:20 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Some example apps rely on driver-specific functionality and link
> explicitly
> > against those drivers. These apps need their makefiles updated to take
> > account of the renaming of the driver libs.
> >
> > Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Applied, thanks Bruce.
> 
> 
> I think the documentation would also need some fixes as I can see a
> lot of references to librte_pmd_.
> 

First draft patchset sent, based off grepping the docs for "librte_pmd_".

http://patches.dpdk.org/project/dpdk/list/?series=13578

/Bruce

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-02 17:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 17:19 [dpdk-dev] [PATCH] examples: fix linking against specific drivers Bruce Richardson
2020-10-30 13:35 ` David Marchand
2020-11-02 17:47   ` Richardson, Bruce

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git