Re: release candidate 23.03-rc1

[David Marchand <david.marchand@redhat.com>]

On Wed, Mar 1, 2023 at 12:16 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Mar 1, 2023 at 9:26 AM David Marchand <david.marchand@redhat.com> wrote:
> >
> > On Wed, Mar 1, 2023 at 8:38 AM Jiang, YuX <yux.jiang@intel.com> wrote:
> > > > -----Original Message-----
> > > > From: Jiang, YuX
> > > > Sent: Thursday, February 23, 2023 4:39 PM
> > > > To: Thomas Monjalon <thomas@monjalon.net>; dev (dev@dpdk.org)
> > > > <dev@dpdk.org>
> > > > Cc: Kovacevic, Marko <Marko.Kovacevic@intel.com>; Mcnamara, John
> > > > <john.mcnamara@intel.com>; Richardson, Bruce
> > > > <bruce.richardson@intel.com>; Ferruh Yigit <ferruh.yigit@xilinx.com>
> > > > Subject: RE: release candidate 23.03-rc1
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Tuesday, February 21, 2023 12:49 AM
> > > > > To: announce@dpdk.org
> > > > > Subject: release candidate 23.03-rc1
> > > > >
> > > > > A new DPDK release candidate is ready for testing:
> > > > >     https://git.dpdk.org/dpdk/tag/?id=v23.03-rc1
> > > > >
> > > > > There are 566 new patches in this snapshot.
> > > > >
> > > > > Release notes:
> > > > >     https://doc.dpdk.org/guides/rel_notes/release_23_03.html
> > > > >
> > > > > Highlights of 23.03-rc1:
> > > > >     - lock annotations
> > > > >     - ARM power management monitor/wakeup
> > > > >     - queue mapping of aggregated ports
> > > > >     - flow quota
> > > > >     - more flow matching (ICMPv6, IPv6 routing extension)
> > > > >     - more flow actions (flex modify, congestion management)
> > > > >     - SHAKE hash algorithm for crypto
> > > > >     - LZ4 algorithm for compression
> > > > >     - more telemetry endpoints
> > > > >     - more tracepoints
> > > > >
> > > > > Please test and report issues on bugs.dpdk.org.
> > > > >
> > > > > DPDK 23.03-rc2 is expected in two weeks.
> > > > >
> > > > > Thank you everyone
> > > > >
> > > > Update the test status for Intel part. Till now dpdk23.03-rc1 test execution rate
> > > > is 70%. No critical issue is found.
> > > > # Basic Intel(R) NIC testing
> > > > * Build or compile:
> > > >  *Build: cover the build test combination with latest GCC/Clang version and the
> > > > popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.1, Fedora37,
> > > > RHEL8.6/9.1 etc.
> > > >   - All test passed.
> > > >  *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as
> > > > Ubuntu22.04.1 and RHEL8.6.
> > > >   - All test passed with latest dpdk.
> > > > * Meson test & Asan test:
> > > >     new issue:
> > > >       - https://bugs.dpdk.org/show_bug.cgi?id=1162 [dpdk-
> > > > 23.03][asan]ERROR: AddressSanitizer: global-buffer-overflow on address
> > > > 0x000014eff508 at pc 0x00000173c234 bp 0x7fff7993bdd0 sp 0x7fff7993bdc8
> > > >
> > > >     known issue:
> > > >       - https://bugs.dpdk.org/show_bug.cgi?id=1107 [22.11-rc1][meson test]
> > > > seqlock_autotest test failed
> > > >       - https://bugs.dpdk.org/show_bug.cgi?id=1123 [dpdk-22.11][asan] the
> > > > stack-buffer-overflow was found when quit testpmd in Redhat9
> > > > * PF/VF(i40e, ixgbe): test scenarios including PF/VF-
> > > > RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> > > >       - Execution rate is 90%.
> > > >       - Find 1 new bug:
> > > >           [dpdk-23.03] generic_flow_api/fdir_for_ipv6: packets of match rule
> > > > cannot be allocated to the specified queue. -> Intel dev is under investigating.
> > > > * PF/VF(ice): test scenarios including Switch features/Package
> > > > Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> > > > Descriptor, etc.
> > > >       - Execution rate is 80%. No new issue is found.
> > > > * Intel NIC single core/NIC performance: test scenarios including PF/VF single
> > > > core performance test, RFC2544 Zero packet loss performance test, etc.
> > > >       - Execution rate is 80%.
> > > >       - Find 1 performance drop issue, bad commit is 4f8259df5 (net/iavf:
> > > > enable Tx outer checksum offload on AVX512).
> > > >       new fix patch link:
> > > > https://patchwork.dpdk.org/project/dpdk/patch/20230222081311.74488-1-
> > > > zhichaox.zeng@intel.com/
> > > > * Power and IPsec:
> > > >  * Power: test scenarios including bi-direction/Telemetry/Empty Poll
> > > > Lib/Priority Base Frequency, etc.
> > > >       - Execution rate is 50%. No new issue is found.
> > > >  * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> > > > QAT&SW/FIB library, etc.
> > > >       - Execution rate is 50%. No new issue is found.
> > > > # Basic cryptodev and virtio testing
> > > > * Virtio: both function and performance test are covered. Such as
> > > > PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> > > > testing/VMAWARE ESXI 8.0, etc.
> > > >       - Execution rate is 80%. No new issue is found.
> > > > * Cryptodev:
> > > >  *Function test: test scenarios including Cryptodev API testing/CompressDev
> > > > ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> > > >       - Execution rate is 50%. No new issue is found.
> > > >  *Performance test: test scenarios including Throughput Performance
> > > > /Cryptodev Latency, etc.
> > > >       - Execution rate is 50%. No performance drop.
> > > >
> > > > Best regards,
> > > > Yu Jiang
> > >
> > > Update the test status for Intel part. Till now dpdk23.03-rc1 test is almost finished. No critical issue is found.
> > > # Basic Intel(R) NIC testing
> > > * Build or compile:
> > >  *Build: cover the build test combination with latest GCC/Clang version and the popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.1, Fedora37, RHEL8.6/9.1 etc.
> > >   - All test passed.
> > >  *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.1 and RHEL8.6.
> > >   - All test passed with latest dpdk.
> > > * Meson test & Asan test:
> > >     new issue:
> > >         - https://bugs.dpdk.org/show_bug.cgi?id=1162 [dpdk23.03-rc1][asan]ERROR: AddressSanitizer: global-buffer-overflow on address 0x000014eff508 at pc 0x00000173c234 bp 0x7fff7993bdd0 sp 0x7fff7993bdc8
> > >         - https://bugs.dpdk.org/show_bug.cgi?id=1166 [dpdk-23.03][asan]vf_smoke/vf_tx_rx_queue: AddressSanitizer: stack-buffer-overflow error when quit testpmd
> > >                 - Still no response from dpdk community, hope it can be fixed asap, since it blocks our asan test.
> >
> > I marked it as a duplicate of https://bugs.dpdk.org/show_bug.cgi?id=1123.
> >
> > >         - https://bugs.dpdk.org/show_bug.cgi?id=1123 [dpdk-22.11][asan] the stack-buffer-overflow was found when quit testpmd in Redhat9
> >
> > This ASan backtrace is strange.
> >
> > I can't replicate with clang built binaries.
> > Please double check with clang and report back in the bz.
> > I'll try to have a look once I hear back.
>
> This backtrace was ringing a bell... I finally realised it was
> https://bugs.dpdk.org/show_bug.cgi?id=823 that I had opened last year.
> The key point seems to be compiling with gcc *and* -O0 to get the ASan splat.
>
> Here is my reproducer:
> $ rm -rf build-mini; CC='ccache gcc' meson setup build-mini
> -Ddisable_libs=* -Denable_drivers=net/null -Denable_apps=test-pmd
> -Dtests=false -Db_sanitize=address -Dbuildtype=debug && ninja -C
> build-mini && ./devtools/test-null.sh build-mini
>
> For now, Intel QE might want to disable the sigaltstack mangling in
> ASan, that will unblock further testing with ASan.
> Like:
> $ ASAN_OPTIONS=use_sigaltstack=0 ./devtools/test-null.sh build-mini

I put more details in the 823 bugzilla.

Afaiu, this is a bug in ASan itself.
clang 15 is not affected.
gcc 13 libasan also seems fixed.

I'll close this bugzilla as INVALID since this is an issue external to DPDK.
A workaround is to disable sigaltstack by setting
"ASAN_OPTIONS=use_sigaltstack=0" before running your tests.


Thanks.

-- 
David Marchand