From: David Marchand <david.marchand@redhat.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>, Rahul Shah <rahul.r.shah@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted
Date: Fri, 10 Sep 2021 09:36:51 +0200 [thread overview]
Message-ID: <CAJFAV8xA2Yc3uFXROYnpisp3R4vhudqzwi2S-FGUQXgUoW38Hw@mail.gmail.com> (raw)
In-Reply-To: <55677da6-68cf-eb65-e5bb-004a4bf970c5@ashroe.eu>
On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray <mdr@ashroe.eu> wrote:
> On 09/09/2021 17:40, Rahul Shah wrote:
> > rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops,
> > rte_port_eventdev_writer_ops symbols promoted
> >
> > Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
> > ---
> > lib/port/version.map | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> >
>
> Hi Rahul,
>
> You need to strip the __rte_experimental attribute in the header file also.
That's what I first thought... but those are variables, and there were
not marked in the header.
At least, those symbols must be alphabetically sorted in version.map.
About checking for experimental mark on variables... I had a patch,
but never got it in.
I think we should instead (forbid such exports and|insist on) rework
API / libraries that rely on public variables.
--
David Marchand
next prev parent reply other threads:[~2021-09-10 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 16:40 Rahul Shah
2021-09-10 7:30 ` Kinsella, Ray
2021-09-10 7:36 ` David Marchand [this message]
2021-09-10 13:40 ` Kinsella, Ray
2021-10-13 12:12 ` Thomas Monjalon
2021-10-20 9:55 ` Kinsella, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xA2Yc3uFXROYnpisp3R4vhudqzwi2S-FGUQXgUoW38Hw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=rahul.r.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).