Re: [dpdk-dev] [PATCH] buildtools: lighter experimental symbol check

[David Marchand <david.marchand@redhat.com>]

On Mon, Aug 12, 2019 at 10:14 PM Neil Horman <nhorman@tuxdriver.com> wrote:
>
> On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote:
> > Dumping every object file for every symbol is too heavy.
> > Use a temporary storage.
> >
> > Before:
> > $ rm -rf master && make defconfig O=master
> > $ time make EXTRA_CFLAGS=-g O=master
> > [...]
> > real  2m24.063s
> > user  1m16.985s
> > sys   1m46.372s
> >
> > After:
> > $ rm -rf master && make defconfig O=master
> > $ time make EXTRA_CFLAGS=-g O=master
> > [...]
> > real  1m37.110s
> > user  0m49.417s
> > sys   0m51.803s
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  buildtools/check-experimental-syms.sh | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> >
> > diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> > index 0f6c62d..47a06fc 100755
> > --- a/buildtools/check-experimental-syms.sh
> > +++ b/buildtools/check-experimental-syms.sh
> > @@ -18,14 +18,15 @@ then
> >       exit 0
> >  fi
> >
> > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
> > +trap 'rm -f "$DUMPFILE"' EXIT

"If a sigspec is EXIT (0) the command arg is executed on exit from the shell."

> > +objdump -t $OBJFILE >$DUMPFILE
> > +
> When does this temporary file get deleted?

It should be enough?

-- 
David Marchand