From: David Marchand <david.marchand@redhat.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Cc: dev <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>,
Xueming Li <xuemingl@nvidia.com>, dpdk stable <stable@dpdk.org>,
Harman Kalra <hkalra@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device
Date: Thu, 14 Oct 2021 13:20:37 +0200 [thread overview]
Message-ID: <CAJFAV8xKjk5nREu66FO7G1hH+QQVj0LRqMME0mwVhN1h+6p4aQ@mail.gmail.com> (raw)
In-Reply-To: <20211014085528.2992805-1-dkozlyuk@nvidia.com>
On Thu, Oct 14, 2021 at 10:55 AM Dmitry Kozlyuk <dkozlyuk@nvidia.com> wrote:
>
> MLX5 PMD exposes a socket for external tools to dump port state.
> Socket events are listened using an interrupt source of EXT type.
> The socket was closed and the interrupt callback was unregistered
> at program exit, which is incorrect because DPDK could be already
> shut down at this point. Move actions performed at program exit
> to the moment the last MLX5 port is closed. The socket will be opened
> again if later a new MLX5 device is plugged in and probed.
> Also fix comments that were deceisively talking
> about secondary processes instead of external tools.
+1 for fixing those comments.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: Xueming Li <xuemingl@nvidia.com>
> Cc: stable@dpdk.org
>
> Reported-by: Harman Kalra <hkalra@marvell.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
The fix lgtm, thanks.
There is a separate issue I spotted while reviewing.
I'll send a separate fix.
--
David Marchand
next prev parent reply other threads:[~2021-10-14 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 8:50 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2021-10-14 8:55 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-10-14 11:20 ` David Marchand [this message]
2021-10-21 10:36 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xKjk5nREu66FO7G1hH+QQVj0LRqMME0mwVhN1h+6p4aQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=hkalra@marvell.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).