From: David Marchand <david.marchand@redhat.com>
To: Jim Harris <james.r.harris@intel.com>
Cc: dev <dev@dpdk.org>, David Hunt <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error
Date: Mon, 8 Nov 2021 21:40:28 +0100 [thread overview]
Message-ID: <CAJFAV8xv+6UemF_+E3+z+9_+_6dFdOQ=eeW2z-f81WUVS0x14A@mail.gmail.com> (raw)
In-Reply-To: <20211105155351.350403-1-james.r.harris@intel.com>
On Fri, Nov 5, 2021 at 4:57 PM Jim Harris <james.r.harris@intel.com> wrote:
>
> clang-13 rightfully complains that the tot_ppi
> variable in update_stats is set but not used, since
> the final accumulated tot_ppi results isn't used
> anywhere.
>
> Original idea was to just remove the tot_ppi variable,
> but feedback from David Marchand on mailing list was
> that the related ppi_av array in struct priority_worker
> wasn't useful and should be removed. This allows us
> to also remove num_dequeue_pkts_prev and pc from
> struct priority_worker since they are only used in
> conjunction with the ppi_av array.
This library has its internals exposed to the world for no good reason.
I am pretty sure all those structures could be hidden in the .c.
It is still an experimental API: we can hope it gets cleaned up at some point.
This patch that drops dead code is a first step and lgtm.
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2021-11-08 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 15:53 Jim Harris
2021-11-08 20:40 ` David Marchand [this message]
2021-11-12 14:46 ` David Marchand
2021-11-10 10:55 ` [dpdk-dev] " Jiang, YuX
2021-11-10 11:07 ` David Marchand
2021-11-10 11:34 ` Jiang, YuX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xv+6UemF_+E3+z+9_+_6dFdOQ=eeW2z-f81WUVS0x14A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).