From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 00/18] Convert static log types in libraries to dynamic
Date: Wed, 6 Dec 2023 11:08:37 +0100 [thread overview]
Message-ID: <CAJFAV8xvWuBUvgjqUj0f=HyNAX+99Ck=RFWxBcBgFA_Zmj+XGA@mail.gmail.com> (raw)
In-Reply-To: <20231205021330.260017-1-stephen@networkplumber.org>
On Tue, Dec 5, 2023 at 3:13 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> This patchset removes most of the uses of static LOGTYPE's in DPDK
> libraries. It starts with the easy one and goes on to the more complex ones.
>
> There are several options on how to treat the old static types:
> leave them there, mark as deprecated, or remove them.
> This version removes them since there is no guarantee in current
> DPDK policies that says they can't be removed.
Those logtypes were internal things that should not have been public
in the first place.
And switching to a dynamic logtype for external users (if any) is trivial.
>
> Note: there is one patch in this series that will get
> flagged incorrectly as an ABI change.
Adding such stable symbols is not a problem.
We can ignore this warning (which is there to force maintainers to
inspect such additions).
>
> v14 - rebase on 24.03-rc0
> skip port, table and pipeline libraries since lots of
> to be deprecated code.
>
> v13 - rebase because log now moved.
>
> v12 - rebase and add table and pipeline libraries
>
> v11 - fix include check on arm cross build
>
> v10 - add necessary rte_compat.h in thash_gfni stub for arm
>
> v9 - fix handling of crc32 alg in lib/hash.
> make it an internal global variable.
> fix gfni stubs for case where they are not used.
>
> Stephen Hemminger (18):
> gso: don't log message on non TCP/UDP
> eal: drop no longer used GSO logtype
> log: drop unused RTE_LOGTYPE_TIMER
> efd: convert RTE_LOGTYPE_EFD to dynamic type
> mbuf: convert RTE_LOGTYPE_MBUF to dynamic type
> acl: convert RTE_LOGTYPE_ACL to dynamic type
> examples/power: replace use of RTE_LOGTYPE_POWER
> examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER
> power: convert RTE_LOGTYPE_POWER to dynamic type
> ring: convert RTE_LOGTYPE_RING to dynamic type
> mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type
> lpm: convert RTE_LOGTYPE_LPM to dynamic types
> sched: convert RTE_LOGTYPE_SCHED to dynamic type
> examples/ipsec-secgw: replace RTE_LOGTYPE_PORT
> app/test: remove use of RTE_LOGTYPE_PIPELINE
> hash: mover rte_thash_gfni stubs out of header file
> hash: move rte_hash_set_alg out of header file
> hash: convert RTE_LOGTYPE_HASH to dynamic type
>
> app/test/test_acl.c | 2 +-
> app/test/test_table_acl.c | 50 ++++++++++++-------------
> app/test/test_table_pipeline.c | 40 ++++++++++----------
> examples/distributor/main.c | 2 +-
> examples/ipsec-secgw/sa.c | 6 +--
> examples/l3fwd-power/main.c | 17 +++++----
> lib/acl/acl.h | 1 +
> lib/acl/acl_bld.c | 3 ++
> lib/acl/acl_gen.c | 1 +
> lib/acl/acl_log.h | 6 +++
> lib/acl/rte_acl.c | 3 ++
> lib/acl/tb_mem.c | 3 +-
> lib/efd/rte_efd.c | 4 ++
> lib/fib/fib_log.h | 4 ++
> lib/fib/rte_fib.c | 3 ++
> lib/fib/rte_fib6.c | 2 +
> lib/gso/rte_gso.c | 4 +-
> lib/gso/rte_gso.h | 1 +
> lib/hash/meson.build | 9 ++++-
> lib/hash/rte_crc_arm64.h | 8 ++--
> lib/hash/rte_crc_x86.h | 10 ++---
> lib/hash/rte_cuckoo_hash.c | 5 +++
> lib/hash/rte_fbk_hash.c | 5 +++
> lib/hash/rte_hash_crc.c | 68 ++++++++++++++++++++++++++++++++++
> lib/hash/rte_hash_crc.h | 48 ++----------------------
> lib/hash/rte_thash.c | 3 ++
> lib/hash/rte_thash_gfni.c | 50 +++++++++++++++++++++++++
> lib/hash/rte_thash_gfni.h | 23 +++---------
> lib/hash/version.map | 9 +++++
> lib/log/log.c | 13 -------
> lib/log/rte_log.h | 26 ++++++-------
> lib/lpm/lpm_log.h | 4 ++
> lib/lpm/rte_lpm.c | 3 ++
> lib/lpm/rte_lpm6.c | 1 +
> lib/mbuf/mbuf_log.h | 4 ++
> lib/mbuf/rte_mbuf.c | 4 ++
> lib/mbuf/rte_mbuf_dyn.c | 2 +
> lib/mbuf/rte_mbuf_pool_ops.c | 2 +
> lib/mempool/rte_mempool.c | 2 +
> lib/mempool/rte_mempool.h | 8 ++++
> lib/mempool/version.map | 3 ++
> lib/power/power_common.c | 2 +
> lib/power/power_common.h | 2 +
> lib/power/power_kvm_vm.c | 1 +
> lib/power/rte_power.c | 1 +
> lib/power/rte_power_uncore.c | 1 +
> lib/rib/rib_log.h | 4 ++
> lib/rib/rte_rib.c | 3 ++
> lib/rib/rte_rib6.c | 3 ++
> lib/ring/rte_ring.c | 3 ++
> lib/sched/rte_pie.c | 1 +
> lib/sched/rte_sched.c | 5 +++
> lib/sched/rte_sched_log.h | 4 ++
> 53 files changed, 329 insertions(+), 163 deletions(-)
> create mode 100644 lib/acl/acl_log.h
> create mode 100644 lib/fib/fib_log.h
> create mode 100644 lib/hash/rte_hash_crc.c
> create mode 100644 lib/hash/rte_thash_gfni.c
> create mode 100644 lib/lpm/lpm_log.h
> create mode 100644 lib/mbuf/mbuf_log.h
> create mode 100644 lib/rib/rib_log.h
> create mode 100644 lib/sched/rte_sched_log.h
I fixed a few issues:
- added a release note update for the gso patch,
- fixed some styling issues in meson updates,
- reordered some hunks and patches,
- dropped some whitespace damage and typos,
- dropped unneeded include of rte_compat.h,
- fixed indent,
- marked exported variables as stable (such variable is part of the
application ABI),
Series applied.
--
David Marchand
prev parent reply other threads:[~2023-12-06 10:08 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 23:40 [PATCH v12 00/22] Covert " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 01/22] gso: don't log message on non TCP/UDP Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 02/22] eal: drop no longer used GSO logtype Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 03/22] log: drop unused RTE_LOGTYPE_TIMER Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 04/22] efd: convert RTE_LOGTYPE_EFD to dynamic type Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 05/22] mbuf: convert RTE_LOGTYPE_MBUF " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 06/22] acl: convert RTE_LOGTYPE_ACL " Stephen Hemminger
2023-06-05 13:40 ` Константин Ананьев
2023-03-29 23:40 ` [PATCH v12 07/22] examples/power: replace use of RTE_LOGTYPE_POWER Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 08/22] examples/l3fwd-power: " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 09/22] power: convert RTE_LOGTYPE_POWER to dynamic type Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 10/22] ring: convert RTE_LOGTYPE_RING " Stephen Hemminger
2023-06-05 13:41 ` Константин Ананьев
2023-03-29 23:40 ` [PATCH v12 11/22] mempool: convert RTE_LOGTYPE_MEMPOOL " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 12/22] lpm: convert RTE_LOGTYPE_LPM to dynamic types Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 13/22] kni: convert RTE_LOGTYPE_KNI to dynamic type Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 14/22] sched: convert RTE_LOGTYPE_SCHED " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 15/22] examples/ipsec-secgw: replace RTE_LOGTYPE_PORT Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 16/22] port: convert RTE_LOGTYPE_PORT to dynamic type Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 17/22] hash: move rte_thash_gfni stubs out of header file Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 18/22] hash: move rte_hash_set_alg out header Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 19/22] hash: convert RTE_LOGTYPE_HASH to dynamic type Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 20/22] table: convert RTE_LOGTYPE_TABLE " Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 21/22] app/test: remove use of RTE_LOGTYPE_PIPELINE Stephen Hemminger
2023-03-29 23:40 ` [PATCH v12 22/22] pipeline: convert RTE_LOGTYPE_PIPELINE to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 00/21] Convert static log types in libraries to dynamic types Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 01/21] gso: don't log message on non TCP/UDP Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 02/21] eal: drop no longer used GSO logtype Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 03/21] log: drop unused RTE_LOGTYPE_TIMER Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 04/21] efd: convert RTE_LOGTYPE_EFD to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 05/21] mbuf: convert RTE_LOGTYPE_MBUF " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 06/21] acl: convert RTE_LOGTYPE_ACL " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 07/21] examples/power: replace use of RTE_LOGTYPE_POWER Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 08/21] examples/l3fwd-power: " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 09/21] power: convert RTE_LOGTYPE_POWER to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 10/21] ring: convert RTE_LOGTYPE_RING " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 11/21] mempool: convert RTE_LOGTYPE_MEMPOOL " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 12/21] lpm: convert RTE_LOGTYPE_LPM to dynamic types Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 13/21] sched: convert RTE_LOGTYPE_SCHED to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 14/21] examples/ipsec-secgw: replace RTE_LOGTYPE_PORT Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 15/21] port: convert RTE_LOGTYPE_PORT to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 16/21] hash: move rte_thash_gfni stubs out of header file Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 17/21] hash: move rte_hash_set_alg out header Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 18/21] hash: convert RTE_LOGTYPE_HASH to dynamic type Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 19/21] table: convert RTE_LOGTYPE_TABLE " Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 20/21] app/test: remove use of RTE_LOGTYPE_PIPELINE Stephen Hemminger
2023-08-21 16:09 ` [PATCH v13 21/21] pipeline: convert RTE_LOGTYPE_PIPELINE to dynamic type Stephen Hemminger
2023-12-04 12:32 ` [PATCH v13 00/21] Convert static log types in libraries to dynamic types David Marchand
2023-12-05 2:09 ` [PATCH 00/18] Convert static log types in libraries to dynamic Stephen Hemminger
2023-12-05 2:09 ` [PATCH 01/18] gso: don't log message on non TCP/UDP Stephen Hemminger
2023-12-05 2:09 ` [PATCH 02/18] eal: drop no longer used GSO logtype Stephen Hemminger
2023-12-05 2:09 ` [PATCH 03/18] log: drop unused RTE_LOGTYPE_TIMER Stephen Hemminger
2023-12-05 2:09 ` [PATCH 04/18] efd: convert RTE_LOGTYPE_EFD to dynamic type Stephen Hemminger
2023-12-05 2:09 ` [PATCH 05/18] mbuf: convert RTE_LOGTYPE_MBUF " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 06/18] acl: convert RTE_LOGTYPE_ACL " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 07/18] examples/power: replace use of RTE_LOGTYPE_POWER Stephen Hemminger
2023-12-05 2:09 ` [PATCH 08/18] examples/l3fwd-power: " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 09/18] power: convert RTE_LOGTYPE_POWER to dynamic type Stephen Hemminger
2023-12-05 2:09 ` [PATCH 10/18] ring: convert RTE_LOGTYPE_RING " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 11/18] mempool: convert RTE_LOGTYPE_MEMPOOL " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 12/18] lpm: convert RTE_LOGTYPE_LPM to dynamic types Stephen Hemminger
2023-12-05 2:09 ` [PATCH 13/18] sched: convert RTE_LOGTYPE_SCHED to dynamic type Stephen Hemminger
2023-12-05 2:09 ` [PATCH 14/18] examples/ipsec-secgw: replace RTE_LOGTYPE_PORT Stephen Hemminger
2023-12-05 2:09 ` [PATCH 15/18] app/test: remove use of RTE_LOGTYPE_PIPELINE Stephen Hemminger
2023-12-05 2:09 ` [PATCH 16/18] hash: mover rte_thash_gfni stubs out of header file Stephen Hemminger
2023-12-05 2:09 ` [PATCH 17/18] hash: move rte_hash_set_alg " Stephen Hemminger
2023-12-05 2:09 ` [PATCH 18/18] hash: convert RTE_LOGTYPE_HASH to dynamic type Stephen Hemminger
2023-12-06 10:08 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xvWuBUvgjqUj0f=HyNAX+99Ck=RFWxBcBgFA_Zmj+XGA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).