From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Beilei Xing <beilei.xing@intel.com>,
Jeff Guo <jia.guo@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Qian Xu <qian.q.xu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Tal Shnaiderman <talshn@mellanox.com>,
Raslan <rasland@mellanox.com>, Asaf Penso <asafp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource
Date: Wed, 23 Sep 2020 09:34:27 +0200 [thread overview]
Message-ID: <CAJFAV8xxTMNM4cJHRRBwbZSkJ8E7YFk0sDpiAOytUezG4cuygg@mail.gmail.com> (raw)
In-Reply-To: <3033441.08XpM1RNeG@thomas>
On Fri, Jul 10, 2020 at 12:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > It took me some time to understand this code...
> > Anyway, we have a regression in the librte_pci.
> > This is where the fix should be.
>
> Yes, I am going to send a fix.
>
> > We can cleanup this code later.
>
> Yes please, this function isn't understandable and lack of comments.
> Anatoly please?
Now that the workaround on the pci mapping API has been reverted, we
are back with this issue.
https://bugs.dpdk.org/show_bug.cgi?id=539
Volunteer(s) to fix and clean this code?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-09-23 7:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:24 alvinx.zhang
2020-07-08 9:38 ` David Marchand
2020-07-08 13:58 ` Xia, Chenbo
2020-07-09 5:13 ` Zhang, AlvinX
2020-07-09 5:21 ` Xia, Chenbo
2020-07-09 2:25 ` Xiao, QimaiX
2020-07-10 9:54 ` David Marchand
2020-07-10 10:07 ` Thomas Monjalon
2020-07-10 12:31 ` Thomas Monjalon
2020-07-10 12:43 ` [dpdk-dev] [dpdk-ci] " Lincoln Lavoie
2020-09-23 7:34 ` David Marchand [this message]
2020-07-11 6:57 ` [dpdk-dev] " Zhang, AlvinX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xxTMNM4cJHRRBwbZSkJ8E7YFk0sDpiAOytUezG4cuygg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=alvinx.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=asafp@mellanox.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=john.mcnamara@intel.com \
--cc=qian.q.xu@intel.com \
--cc=rasland@mellanox.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).