From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH 0/2] simplify building x86 code with AVX2 support
Date: Thu, 12 Oct 2023 14:37:49 +0200 [thread overview]
Message-ID: <CAJFAV8y-paYwWsrcQBMMOqc84W6FqF9d7NuNei158Wjyt2ucqw@mail.gmail.com> (raw)
In-Reply-To: <20230727093107.7242-1-bruce.richardson@intel.com>
Hello Bruce,
On Thu, Jul 27, 2023 at 11:31 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Inside our optimized vector drivers (and libs), there were always build
> time checks for various levels of instruction set support, most
> notably AVX2 and AVX-512 on x86 systems. One of the checks done in
> each case was verifying that the compiler used was able to generate
> AVX code appropriately. However, since this was originally done,
> our minimum compiler support has been updated and so we no longer
> need to check this - all supported compilers can generate AVX2.
> This allows us to simplify the build logic for the x86 vector code.
>
> In future, we can do similarly for AVX-512.
>
> Bruce Richardson (2):
> build/x86: remove conditional checks for AVX2 support
> build: remove unnecessary AVX2 compiler flag
>
> drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----
> drivers/net/bnxt/bnxt_rxr.h | 2 +-
> drivers/net/bnxt/bnxt_txr.h | 2 +-
> drivers/net/bnxt/meson.build | 26 +++++++++----------------
> drivers/net/enic/meson.build | 10 +++-------
> drivers/net/i40e/i40e_rxtx.c | 14 ++++---------
> drivers/net/i40e/meson.build | 22 ++++++---------------
> drivers/net/iavf/iavf_rxtx_vec_common.h | 2 +-
> drivers/net/iavf/meson.build | 22 ++++++---------------
> drivers/net/ice/meson.build | 21 ++++++--------------
> lib/acl/meson.build | 23 +++++-----------------
> lib/acl/rte_acl.c | 10 +++-------
> 12 files changed, 49 insertions(+), 113 deletions(-)
Sorry, this series had fallen through the cracks... though I intended
to apply with other build update series.
It still applies fine, I ran my checks and I see nothing wrong with the series.
Applied, thanks for the cleanup.
--
David Marchand
prev parent reply other threads:[~2023-10-12 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 9:31 Bruce Richardson
2023-07-27 9:31 ` [PATCH 1/2] build/x86: remove conditional checks for " Bruce Richardson
2023-07-27 9:31 ` [PATCH 2/2] build: remove unnecessary AVX2 compiler flag Bruce Richardson
2023-10-12 12:37 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8y-paYwWsrcQBMMOqc84W6FqF9d7NuNei158Wjyt2ucqw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).