DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Jerin Jacob <jerinj@marvell.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v4 2/2] event/skeleton: set driver name string
Date: Wed, 18 Oct 2023 14:44:11 +0200	[thread overview]
Message-ID: <CAJFAV8y80L4C2HeEnKRqTRob+_iMzjpfgpvQJ5ugHh7Xc+=_AQ@mail.gmail.com> (raw)
In-Reply-To: <20231018122558.126686-2-bruce.richardson@intel.com>

On Wed, Oct 18, 2023 at 2:26 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When calling rte_eventdev_info_get() the driver name string field should
> be populated.
>
> Fixes: bbbb929da5e6 ("event/skeleton: add skeleton eventdev driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

event/dpaa2 seems affected too.

Can rte_eventdev_info_get() fill this based on the driver attached to
the device, like ethdev does?

Something like untested:

diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 95373bbaad..37ccc0dc77 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -104,6 +104,7 @@ rte_event_dev_info_get(uint8_t dev_id, struct
rte_event_dev_info *dev_info)
        dev_info->dequeue_timeout_ns = dev->data->dev_conf.dequeue_timeout_ns;

        dev_info->dev = dev->dev;
+       dev_info->driver_name = dev->dev->driver->name;

        rte_eventdev_trace_info_get(dev_id, dev_info, dev_info->dev);


-- 
David Marchand


  reply	other threads:[~2023-10-18 12:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 15:17 [PATCH] event/sw: fix missing device pointer Bruce Richardson
2023-10-17 12:45 ` Van Haaren, Harry
2023-10-17 15:51 ` [PATCH v2 1/2] " Bruce Richardson
2023-10-17 15:51   ` [PATCH v2 2/2] event/dsw: " Bruce Richardson
2023-10-17 16:46 ` [PATCH v3 0/4] Fix device info for SW eventdevs Bruce Richardson
2023-10-17 16:46   ` [PATCH v3 1/4] event/sw: fix missing device pointer Bruce Richardson
2023-10-17 16:46   ` [PATCH v3 2/4] event/dsw: " Bruce Richardson
2023-10-18  6:27     ` Mattias Rönnblom
2023-10-17 16:46   ` [PATCH v3 3/4] event/skeleton: " Bruce Richardson
2023-10-17 16:46   ` [PATCH v3 4/4] event/skeleton: set driver name string Bruce Richardson
2023-10-18 12:25 ` [PATCH v4 1/2] event/*: set device pointer for vdev-based eventdevs Bruce Richardson
2023-10-18 12:25   ` [PATCH v4 2/2] event/skeleton: set driver name string Bruce Richardson
2023-10-18 12:44     ` David Marchand [this message]
2023-10-18 12:52       ` Bruce Richardson
2023-10-18 13:42         ` Bruce Richardson
2023-10-18 13:01   ` [PATCH v4 1/2] event/*: set device pointer for vdev-based eventdevs David Marchand
2023-10-18 13:39 ` [PATCH v5 1/2] eventdev: fix " Bruce Richardson
2023-10-18 13:39   ` [PATCH v5 2/2] eventdev: fix missing driver names in info struct Bruce Richardson
2023-10-19  5:35     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y80L4C2HeEnKRqTRob+_iMzjpfgpvQJ5ugHh7Xc+=_AQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).