From: David Marchand <david.marchand@redhat.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Ian Stokes <ian.stokes@intel.com>,
Ilya Maximets <i.maximets@samsung.com>,
Aaron Conole <aconole@redhat.com>
Subject: [dpdk-dev] Forcing inlining for igb_uio and kni
Date: Tue, 11 Jun 2019 10:45:33 +0200 [thread overview]
Message-ID: <CAJFAV8yJ_SAvSQ-gK4dAuQmFFuYRqzz8qswmtDHEM1NV1oahXQ@mail.gmail.com> (raw)
I noticed that OVS CI [1] patches the dpdk sources to force some inlining
parameters and get kni and igb_uio to build fine.
Looking at it in dpdk, meson support dropped this.
In the makefiles, I can't find a reason in the git history (we go back to
1.3.0rX version).
[dmarchan@dmarchan dpdk]$ git grep max-inline-insns-single
kernel/linux/igb_uio/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=100
kernel/linux/kni/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=50
[dmarchan@dmarchan dpdk]$ git blame origin/master --
kernel/linux/igb_uio/Makefile |grep max-inline-insns-single
13dc56a6 lib/librte_eal/linuxapp/igb_uio/Makefile (Intel
2012-12-20 00:00:00 +0100 15) MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=100
[dmarchan@dmarchan dpdk]$ git blame origin/master --
kernel/linux/kni/Makefile |grep max-inline-insns-single
3fc5ca2f lib/librte_eal/linuxapp/kni/Makefile (Intel 2012-12-20
00:00:00 +0100 14) MODULE_CFLAGS += -I$(SRCDIR) --param
max-inline-insns-single=50
Is there a valid reason to keep this?
1: https://github.com/openvswitch/ovs/blob/master/.travis/linux-build.sh#L81
--
David Marchand
next reply other threads:[~2019-06-11 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190611084549epcas5p42a1a9b787cf71df23f18ebaf4092beaa@epcas5p4.samsung.com>
2019-06-11 8:45 ` David Marchand [this message]
2019-06-11 9:31 ` Ilya Maximets
2019-06-11 9:44 ` David Marchand
2019-06-11 10:18 ` Bruce Richardson
2019-06-11 14:25 ` Stephen Hemminger
2019-06-11 14:36 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yJ_SAvSQ-gK4dAuQmFFuYRqzz8qswmtDHEM1NV1oahXQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@samsung.com \
--cc=ian.stokes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).