* [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type
@ 2023-12-11 20:32 Stephen Hemminger
2023-12-12 7:53 ` David Marchand
2024-01-12 11:03 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2023-12-11 20:32 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Jerin Jacob
With a little setup in eventdev_pmd.h the eventdev drivers
and API can be converted to dynamic log type.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eventdev/eventdev_pmd.h | 3 +++
lib/eventdev/rte_eventdev.c | 2 ++
lib/eventdev/version.map | 1 +
lib/log/log.c | 1 -
lib/log/rte_log.h | 2 +-
5 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
index 30bd90085c44..52dc1a1d79fb 100644
--- a/lib/eventdev/eventdev_pmd.h
+++ b/lib/eventdev/eventdev_pmd.h
@@ -31,6 +31,9 @@ extern "C" {
#include "event_timer_adapter_pmd.h"
#include "rte_eventdev.h"
+extern int rte_event_logtype;
+#define RTE_LOGTYPE_EVENTDEV rte_event_logtype
+
/* Logging Macros */
#define RTE_EDEV_LOG_ERR(...) \
RTE_LOG(ERR, EVENTDEV, \
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 0ca32d672175..10ea7f626e66 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -28,6 +28,8 @@
#include "eventdev_pmd.h"
#include "eventdev_trace.h"
+RTE_LOG_REGISTER_DEFAULT(rte_event_logtype, INFO);
+
static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS];
struct rte_eventdev *rte_eventdevs = rte_event_devices;
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index 3d5c6c2b835c..964cd6444169 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -75,6 +75,7 @@ DPDK_24 {
rte_event_eth_tx_adapter_stats_reset;
rte_event_eth_tx_adapter_stop;
rte_event_fp_ops;
+ rte_event_logtype;
rte_event_port_attr_get;
rte_event_port_default_conf_get;
rte_event_port_link;
diff --git a/lib/log/log.c b/lib/log/log.c
index e3cd4cff0fbc..6314b6ba8e30 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -357,7 +357,6 @@ static const struct logtype logtype_strings[] = {
{RTE_LOGTYPE_TABLE, "lib.table"},
{RTE_LOGTYPE_PIPELINE, "lib.pipeline"},
{RTE_LOGTYPE_CRYPTODEV, "lib.cryptodev"},
- {RTE_LOGTYPE_EVENTDEV, "lib.eventdev"},
{RTE_LOGTYPE_USER1, "user1"},
{RTE_LOGTYPE_USER2, "user2"},
{RTE_LOGTYPE_USER3, "user3"},
diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h
index 27fb6129a7aa..4bdb4e518a71 100644
--- a/lib/log/rte_log.h
+++ b/lib/log/rte_log.h
@@ -45,7 +45,7 @@ extern "C" {
/* was RTE_LOGTYPE_MBUF */
#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
/* was RTE_LOGTYPE_EFD */
-#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */
+ /* was RTE_LOGTYPE_EVENTDEV */
/* was RTE_LOGTYPE_GSO */
/* these log types can be used in an application */
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type
2023-12-11 20:32 [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type Stephen Hemminger
@ 2023-12-12 7:53 ` David Marchand
2023-12-12 8:05 ` David Marchand
2024-01-12 11:03 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-12-12 7:53 UTC (permalink / raw)
To: Stephen Hemminger, Jerin Jacob; +Cc: dev
On Mon, Dec 11, 2023 at 9:33 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> With a little setup in eventdev_pmd.h the eventdev drivers
> and API can be converted to dynamic log type.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
LGTM (with a comment on logtype).
Jerin, can I take this patch directly through main?
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type
2023-12-12 7:53 ` David Marchand
@ 2023-12-12 8:05 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-12-12 8:05 UTC (permalink / raw)
To: Stephen Hemminger, Jerin Jacob; +Cc: dev
On Tue, Dec 12, 2023 at 8:53 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Dec 11, 2023 at 9:33 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > With a little setup in eventdev_pmd.h the eventdev drivers
> > and API can be converted to dynamic log type.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> LGTM (with a comment on logtype).
Scratch that, this is already a driver header, hence internal.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type
2023-12-11 20:32 [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type Stephen Hemminger
2023-12-12 7:53 ` David Marchand
@ 2024-01-12 11:03 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2024-01-12 11:03 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Jerin Jacob
On Mon, Dec 11, 2023 at 9:33 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> With a little setup in eventdev_pmd.h the eventdev drivers
> and API can be converted to dynamic log type.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-12 11:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 20:32 [PATCH] eventdev: replace RTE_LOGTYPE_EVENTDEV with a dynamic type Stephen Hemminger
2023-12-12 7:53 ` David Marchand
2023-12-12 8:05 ` David Marchand
2024-01-12 11:03 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).