From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] eal: rename state values in rte_lcore_state
Date: Thu, 20 Jun 2019 13:03:42 +0200 [thread overview]
Message-ID: <CAJFAV8ypT8v39dRaWTp3ARJ4iOtVCn8sUXfw0_eZ1YmPk0VotA@mail.gmail.com> (raw)
In-Reply-To: <20190619192215.25923-1-stephen@networkplumber.org>
On Wed, Jun 19, 2019 at 9:24 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> C language does not really treat enum's as first class symbols.
> The values in an enum live in a global namespace. That means if
> DPDK defines "RUNNING" it can't be used by another enum in an
> application using DPDK.
>
> To solve this add a prefix "RTE_LCORE_" to the enum values, and
> make them grammatically consistent.
>
> Also, simplify the inline thread_is_running() which is copied
> in softnic and ip_pipeline.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v4 - rebase (after lcore changes),fix FreeBSD typo
>
>
Did an extra pass, you missed the windows eal and the api descriptions:
https://github.com/david-marchand/dpdk/commit/0084114455a82f90b783bdf1659a4af6f76c89f2
My only objection to this patch is that we are breaking a public API by
removing those enums.
We need to maintain those and send a deprecation notice for their future
removal.
--
David Marchand
prev parent reply other threads:[~2019-06-20 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 19:22 Stephen Hemminger
2019-06-20 11:03 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ypT8v39dRaWTp3ARJ4iOtVCn8sUXfw0_eZ1YmPk0VotA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).